Web Client: Bill Full Details - can't save column configuration

Bug #1729435 reported by Terran McCanna
28
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.1
Fix Released
Medium
Unassigned
3.2
Fix Released
Medium
Unassigned
3.4
Fix Released
Medium
Unassigned

Bug Description

In 3.0.1...

When viewing the full details of a bill, there are two grids and it doesn't allow you to save column changes. (Looks like it's probably a similar problem to https://bugs.launchpad.net/evergreen/+bug/1721145.)

Revision history for this message
Laura Sachjen (sachjenl) wrote :

Tested this on a current master sandbox. The columns won't save no matter what is deselected.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Terran McCanna (tmccanna) wrote :

Still cannot save columns in 3.1

Revision history for this message
Remington Steed (rjs7) wrote :

Similar to the fix for bug 1721145, we probably just need an appropriately named persist-key in both eg-grids in circ/patron/t_xact_details_details.tt2 .

tags: added: bitesize
tags: added: webstaffcolumns
Remington Steed (rjs7)
Changed in evergreen:
assignee: nobody → Remington Steed (rjs7)
Revision history for this message
Remington Steed (rjs7) wrote :

Here's the simple fix for both grids on the bills Full Details screen:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1729435_webstaffgrid_persistkey_xact_details_details

To test, you will need to clear your browser cache.

tags: added: pullrequest
Changed in evergreen:
assignee: Remington Steed (rjs7) → nobody
milestone: none → 3.2.2
Revision history for this message
Michele Morgan (mmorgan) wrote :

I tested this on a 3.2.0 system and the fix works to save the column settings in local storage in the browser. However, bug 1750894 moved workstation settings to the database for 3.2 (Yay!). A schema change and db upgrade script is needed to store these in the database as described here:

https://markmail.org/message/szdxnu6lolvhkgjd

I can take a stab at this unless someone beats me to it.

Revision history for this message
Michele Morgan (mmorgan) wrote :

Also see related bug 1774707

Changed in evergreen:
milestone: 3.2.2 → 3.2.3
Revision history for this message
Remington Steed (rjs7) wrote :

Good catch, Michele! It would be great if you can make the upgrade script. Until then, I'll replace the pullrequest tag with needsrepatch.

tags: added: needsrepatch
removed: pullrequest
Changed in evergreen:
milestone: 3.2.3 → 3.3-beta1
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
Michele Morgan (mmorgan)
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Revision history for this message
Michele Morgan (mmorgan) wrote :
tags: added: pullrequest
removed: needsrepatch
Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
Revision history for this message
Michele Morgan (mmorgan) wrote :

I realized I neglected to add the persist key for the bills detail to the upgrade script and seed data. Force pushed to the branch linked above to correct that.

Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Changed in evergreen:
milestone: 3.3.3 → 3.3.4
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

Bill Full Details columns are now saving and are being preserved through deleting my cookies.

I have tested this code and consent to signing off on it with my name, Jennifer Pringle and my email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_4, rel_3_3, rel_3_2, and rel_3_1. Thanks, Remington, Michele, and Jennifer!

Note that for master through rel_3_2, I squashed the two DB update patches into one. For rel_3_1, I pushed only Remington's patch.

Changed in evergreen:
status: Confirmed → Fix Committed
Remington Steed (rjs7)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers