Web Client: Bill Full Details - can't save column configuration

[Terran McCanna]

In 3.0.1...

When viewing the full details of a bill, there are two grids and it doesn't allow you to save column changes. (Looks like it's probably a similar problem to https://bugs.launchpad.net/evergreen/+bug/1721145.)

[Laura Sachjen (sachjenl)]

Tested this on a current master sandbox. The columns won't save no matter what is deselected.

[Terran McCanna (tmccanna)]

Still cannot save columns in 3.1

[Remington Steed (rjs7)]

Similar to the fix for bug 1721145, we probably just need an appropriately named persist-key in both eg-grids in circ/patron/t_xact_details_details.tt2 .

[Remington Steed (rjs7)]

Here's the simple fix for both grids on the bills Full Details screen:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1729435_webstaffgrid_persistkey_xact_details_details

To test, you will need to clear your browser cache.

[Michele Morgan (mmorgan)]

I tested this on a 3.2.0 system and the fix works to save the column settings in local storage in the browser. However, bug 1750894 moved workstation settings to the database for 3.2 (Yay!). A schema change and db upgrade script is needed to store these in the database as described here:

https://markmail.org/message/szdxnu6lolvhkgjd

I can take a stab at this unless someone beats me to it.

[Michele Morgan (mmorgan)]

Also see related bug 1774707

[Remington Steed (rjs7)]

Good catch, Michele! It would be great if you can make the upgrade script. Until then, I'll replace the pullrequest tag with needsrepatch.

[Michele Morgan (mmorgan)]

Pushed a working branch adding seed data changes and an upgrade script:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1729435_webstaffgrid_persistkey_xact_details_details_seed_data

re-adding pullrequest

[Michele Morgan (mmorgan)]

I realized I neglected to add the persist key for the bills detail to the upgrade script and seed data. Force pushed to the branch linked above to correct that.

[Jennifer Pringle (jpringle-u)]

Bill Full Details columns are now saving and are being preserved through deleting my cookies.

I have tested this code and consent to signing off on it with my name, Jennifer Pringle and my email address, <email address hidden>.

[Galen Charlton (gmc)]

Pushed to master, rel_3_4, rel_3_3, rel_3_2, and rel_3_1. Thanks, Remington, Michele, and Jennifer!

Note that for master through rel_3_2, I squashed the two DB update patches into one. For rel_3_1, I pushed only Remington's patch.