Webstaff: setting the record source in the Z39.50 Overlay interface doesn't work

Bug #1727345 reported by Jane Sandberg
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Fix Released
Fix Released
Fix Released

Bug Description

In 2.12.2 and on Webby, take the following steps:

1) Mark a bib record for overlay. Note which bib source is currently marked for this record.
2) Go to Cataloging > Import record from Z39.50
3) Find an awesome new record and click the _Overlay_ button.
4) Click _Edit Z39.50 Record_
5) Change the bib source
6) Click _Modify_
7) Click _Use Edits_
8) Click _Overlay_

When you check the bib record in the catalog, it will still list the original source you noted in step 1, rather than the source that you chose in the z39.50 interface.


Changed in evergreen:
status: New → Confirmed
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

I see this in the 3.1.4 web client

It doesn't look like the new record source is being saved at all.

1. Mark a bib record for overlay
2. Go to Cataloguing -> Import Record from Z39.50
3. Find a new record and click Overlay
4. Click on Edit Z39.50 Record
5. Select a record source
7. Click Save
7. Go back into Edit Z39.50 Record and you'll see that the record source field has gone back to "Select a Source". If you made any edits to the MARC record those edits have been saved.

Revision history for this message
Cesar V (cesardv) wrote :

Branch that addresses the issues of the bib source not being honored when either importing or overlaying via z3950 is here:


(From the commit:)
Two paths to test:
Path A)
    1. Import a new bib record from z3950, but via "Edit then Import"
    2. Bring up marc editor and choose save w/ bib source.
    3. Verify chosen bib source saved correctly on record page.
Path B)
    1. Mark a record as target for Overlay, go to z3950 import.
    2. Make a search, select item for Overlay.
    3. Choose Edit z3950 record to bring up marceditor, save with a bib source.
    4. Verify chosen bib source saved correctly on record page.

tags: added: pullrequest
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.2.2
Changed in evergreen:
milestone: 3.2.2 → 3.2.3
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Awesome, Cesar! Thanks for working on this. Both the import and overlay worked well for me; here's a sign off branch: user/sandbergja/lp1727345-z3950-import-overlay-bibsource-signedoff

tags: added: signedoff
Changed in evergreen:
milestone: 3.2.3 → 3.3-beta1
Revision history for this message
Cesar V (cesardv) wrote :

Thanks all, pushed to master, 3.2 and 3.1

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 14.1.0

This issue was fixed in the openstack/tripleo-heat-templates 14.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.