web client: Alert doesn't display for soon-to-expire patron accounts

[Kathy Lussier]

Evergreen version: master

This bug is for systems that use the "Warn when patron account is about to expire" library setting.

When retrieving a patron whose expiration date falls under the interval set in this library setting, the web client does not display an alert as expected.

In the xul client, the alert, which says 'Patron account will expire soon. Please renew.' displays on the Stop Sign alert screen.

You can replicate this bug by setting a test patron account to expire at the end of the month and then entering 30 days as the value for this setting. If you retrieve the patron account in the web client, you will not get an alert, but it will display in the xul client.

[Kyle Huckins (khuckins)]

I'm unable to replicate this on current master, but I'm not seeing any commits in the history for the two obvious files to check(staff/circ/patron/app.js and staff/services/patron_search.js) that would have resolved it. Is it possible that hatch session storage key eg.circ.last_alerted_patron was set to the specific test patron when encountering the issue?

[Garry Collum (gcollum)]

I can confirm Kathy's original bug. I was not able to get this to work either in current master or in 3.2.8.

[Terran McCanna (tmccanna)]

I did a local fix for this a few years ago. I'll work it up into a proposed patch today.

[Terran McCanna (tmccanna)]

We've been using this modification for the last year or two and it works for us:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1726918_patron_renewal_alert

[Garry Collum (gcollum)]

Thanks Terran. When I was testing your patch, I realized that I had the library setting set incorrectly. I had it set for 30 days, instead of 30. If the setting is set correctly the functionality works. Sorry about that. Your patch may have already made it into master.

[Terran McCanna (tmccanna)]

Heh, well, it helps if I read the actual bug report properly. The patch I submitted actually adds an alert to the patron summary bar as well onto the alert screen! I'll create a separate launchpad for this and submit my fix in case it would be helpful for people.

[Terran McCanna (tmccanna)]

Marking as invalid since the function is already working.