Web staff: Patron bill payment annotation dialog/modal doesn't work

Bug #1722899 reported by Cesar V on 2017-10-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

In the web staff Patron view, if you go to Bills for a patron with some outstanding debt, you can submit a payment on the right. The "Annotate" checkbox, when active, will pop up a prompt/dialog/modal that asks the user to enter the note text. However, this modal is not wired up to actually work and add a note to the submitted payment.

Further, the OK/Cancel buttons don't seem to work on this modal, and if the modals get changed to backdrop:static (i.e clicking outside them does not dismiss them) per bug 1689325, the only way to get out of the modal is hitting the ESC key, otherwise you're stuck in the modal... Forever...

Tested to occur on 3.0 and likely 2.12.

Cesar V (cesardv) wrote :

I have a potential fix for this here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1722899_fix_patron_billpayment_annotate

I am not sure how the payment annotation is working on webby, given tat this seems broken on master.
Regardless, I think the change to egPromptDialog are probably good to have.

tags: added: pullrequest
Terran McCanna (tmccanna) wrote :

Confirmed that this is still broken on 3.0.1 as well. Will try to get Cesar's fix tested soon.

Changed in evergreen:
status: New → Confirmed
Terran McCanna (tmccanna) wrote :

We applied this to our test server running 3.0.1 and annotated payments worked, but then non-annotated payments didn't work.

Cesar V (cesardv) wrote :

Hi Terran, thanks for testing this.

I've pushed new commit to the same branch that adds a small change that checks to prevent the error I think you're seeing... (i.e undefined pay_note.value blowing up, when a payment is non-annotated)

Let me know if there's any further issues.

Terran McCanna (tmccanna) wrote :

Thanks Cesar, that does the trick!

I have tested this code and consent to signing off on it with my name, Terran McCanna and my email address, <email address hidden>.

tags: added: signedoff
Galen Charlton (gmc) on 2017-11-07
Changed in evergreen:
milestone: none → 3.0.2
importance: Undecided → Medium
assignee: nobody → Galen Charlton (gmc)
Galen Charlton (gmc) wrote :

Pushed to master and rel_3_0. Thanks, Cesar and Terran!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers