Web Client: Workstation dropdowns are not alphabetical

Bug #1722383 reported by Terran McCanna
34
This bug affects 8 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

In 3.0.0:

The dropdown list of workstations isn't in alphabetical order. This won't be an issue for most staff who will only have 1 workstation configured, but those who support large consortiums may end up with dozens or even hundreds of workstations in that list. (This was a problem in the xul client as well.)

Revision history for this message
Jane Sandberg (sandbej) wrote :

Just a note that this should probably be fixed for both Evergreen/Open-ILS/src/templates/staff/t_login.tt2 and Evergreen/Open-ILS/src/templates/staff/admin/workstation/t_workstations.tt2 (aka at the main login screen and also in Administration > Workstation > Registered Workstations).

tags: added: sorting
tags: added: bitesize
Revision history for this message
Shula Link (slink-g) wrote :

I have a potential fix at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/slink/LP1722383_web_client_workstation_dropdowns_are_not_alphabetical

I'm putting in a Sandbox request to see if it works, or if there's unintended side effects.

Changed in evergreen:
status: New → Confirmed
Shula Link (slink-g)
Changed in evergreen:
assignee: nobody → Sam Link (slink-g)
Revision history for this message
Shula Link (slink-g) wrote :

Sandbox testing indicates that adding an orderBy filter using the "name" attribute does not provide alphabetical sorting. I've pushed a new commit to the above branch to try a different approach to the sorting.

Revision history for this message
Shula Link (slink-g) wrote :

The prior commit did not work, so I'm taking another swing at the sorting. Commit has been pushed to the above branch. Again.

Revision history for this message
Shula Link (slink-g) wrote :

And I'm stepping away for now. The commit history of that branch will give three examples of nonworking solutions.

Changed in evergreen:
assignee: Sam Link (slink-g) → nobody
Revision history for this message
Shula Link (slink-g) wrote :

I've grabbed this again during bug squashing day here. Possible fix @

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=e94129dc27d794e456cd116fd8316ccea3fe110b

Changed in evergreen:
assignee: nobody → Sam Link (slink-g)
tags: added: pullrequest
Revision history for this message
Dawn Dale (ddale) wrote :

I am testing this bug patch.

Changed in evergreen:
assignee: Sam Link (slink-g) → Dawn Dale (ddale)
Shula Link (slink-g)
Changed in evergreen:
assignee: Dawn Dale (ddale) → nobody
tags: removed: pullrequest
Revision history for this message
Shula Link (slink-g) wrote :

Dawn confirmed the patch as not working:

The issue I'm seeing is in what information exists in an Angular "workstation" object - the "ws" in "ws in workstations" does not openly contain any name data for the branches. Moreover, I have concerns that successfully sorting by branch may break the default workstation being first in the dropdown.

Looking at the code, a function has to be called to generate the actual workstation name - the {{get_ws_label(ws)}} line in the template - so I'm leaning towards actually fixing this is a larger project than it appears on the surface.

Remington Steed (rjs7)
tags: removed: bitesize
Lynn Floyd (lfloyd)
Changed in evergreen:
importance: Undecided → Medium
tags: removed: webstaffclient
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers