Multiple matches on patron barcode completion in web client

Bug #1721610 reported by Jeff Davis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
2.12
Medium
Unassigned

Bug Description

EG 2.12 and 3.0

When retrieving a patron by barcode, the scanned barcode may match multiple patrons due to barcode completion rules. In the XUL client, when there are multiple matches, a dialog appears allowing you to select one of the matching records. In the web client, you don't get to choose; it just retrieves the first matching barcode, which may not be the one you want.

To test:

1. Add a barcode completion rule for BR1, applying to users and set to active, where "BR1" is the prefix.

2. Create a user with barcode "BR100001" and home library BR1.

3. Create another user with barcode "00001".

4. Login to the web client with BR1 as your working location. Go to "Check Out Item" and enter barcode "00001". EG will retrieve one of the two accounts you created; it ought to present a dialog that allows you to choose between BR00001 and 00001 (or none of the above).

A fix for this should probably build on the fix for bug 1699566.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Working branch user/jeffdavis/lp1721610-user-barcode-completion has a fix:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=070debec

For simplicity, I've just reused the barcode choice modal template from bug 1699566.

This fix only applies to the Check Out Items screen. I'm not sure if there are other parts of the web client where we need to handle multiple matching patron barcodes.

Changed in evergreen:
milestone: none → 3.0.1
tags: added: pullrequest webstaffclient
Revision history for this message
Cesar V (cesardv) wrote :

I have tested as described above and this works fine for me.

I've pushed a signoff branch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/jeffdavis_lp1721610-user-barcode-completion

tags: added: signedoff
Changed in evergreen:
milestone: 3.0.1 → 3.0.2
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_0, and rel_2_12. Thanks, Jeff and Cesar!

Changed in evergreen:
importance: Undecided → Medium
status: New → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers