User Buckets: View Batch Changes display problem

Bug #1721139 reported by Terran McCanna on 2017-10-03
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned
3.0
Low
Unassigned
3.1
Low
Unassigned

Bug Description

3.0.0:

In the new user buckets function, if I click View Batch Edits, the pop-up window squashes/overlaps the text and buttons. (See screenshot)

Terran McCanna (tmccanna) wrote :
Andrea Neiman (aneiman) on 2017-11-07
tags: added: webstaffclient
removed: webstafflclient
Garry Collum (gcollum) wrote :

v.3.1.1

The time stamps and buttons overlap in Firefox, but not in Chrome. In Chrome the timestamps wrap by breaking on the second hyphen in the date.

Changed in evergreen:
status: New → Confirmed
Garry Collum (gcollum) wrote :

Here's a branch for a proposed fix.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/LP1721139_user_buckets_view_batch_changes_display_problem

It adds a new class to styles.css.tt2 for wrapping long text. I put it in styles.css with the thought that it can be used for other issues with word-wrapping.

tags: added: pullrequest
Terran McCanna (tmccanna) wrote :

Thanks, Garry!

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

tags: added: signedoff
Galen Charlton (gmc) wrote :

While testing the proposed patch, I noticed that the root problem was that the time fields in question (as well as the user bucket create date and record bucket create date) were not being formatted with the applicable OU date/time format. Consequently, I propose an alternative patch that does not require the word-wrap tweak (although we should keep that in mind in case we need it elsewhere):

user/gmcharlt/lp1721139_date_format_buckets_and_batch_edits

tags: removed: signedoff
Changed in evergreen:
milestone: none → 3.2-rc
importance: Undecided → Low
Garry Collum (gcollum) wrote :

Thanks Galen. I tested both user buckets and record buckets and your patch works perfectly. A signed off branch is at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1721139_date_format_buckets_and_batch_edits-signoff

tags: added: signedoff
Changed in evergreen:
milestone: 3.2-rc → 3.2.1
Galen Charlton (gmc) wrote :

Thanks for testing, Garry! Given the time passed and the straightforward nature of the patch, I've gone and and pushed to this to master, rel_3_2, and rel_3_1.

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers