Add the ability for copy tags to be links

Bug #1721036 reported by Kathy Lussier
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Wishlist
Unassigned

Bug Description

While researching the background of copy tags, aka digital bookplates, in preparation for an On the Road to 3.0 video series, I encountered this first mention of digital bookplates on the mailing list back in 2010 - http://markmail.org/message/xatxeimhev2y63p4. At that time, the idea was to add a URL to public copy notes so that they could link to a visual representation of a bookplate.

I think the addition of a URL field to our new copy tags would be a worthwhile enhancement to the feature.

tags: added: item-tags wishlist
Remington Steed (rjs7)
Changed in evergreen:
status: New → Confirmed
Remington Steed (rjs7)
Changed in evergreen:
assignee: nobody → Remington Steed (rjs7)
Revision history for this message
Remington Steed (rjs7) wrote :

Here's a branch that adds the URL field in the DB, IDL and uses it as a link in the OPAC. (NOTE: If you're applying this patch manually, not building a fresh install, don't forget to copy the IDL both to /openils/conf/ and to /openils/var/web/reports/.)

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1721036_add_url_to_copy_tags

One question: Is there any reason we need to treat the URL more carefully, such as using mkurl()?

Changed in evergreen:
assignee: Remington Steed (rjs7) → nobody
tags: added: pullrequest
Remington Steed (rjs7)
Changed in evergreen:
milestone: 3.next → 3.4-beta1
Kyle Huckins (khuckins)
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Revision history for this message
Kyle Huckins (khuckins) wrote :

To answer your question, I would think the html filter would be sufficient here.

I have tested this code and consent to signing off on it with my name, Kyle Huckins and my email address, <email address hidden>.

Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
tags: added: signedoff
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Pushed to master. Thanks, Remington and Kyle!

Changed in evergreen:
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers