Web client- LSE Toggle off the patron summary sidebar after first view

Bug #1717366 reported by Christine Burns
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned
3.2
Undecided
Unassigned
3.3
Low
Unassigned
3.4
Low
Unassigned
3.5
Low
Unassigned

Bug Description

Library Setting - Toggle off the patron summary sidebar after first view is not working in the web client.

In XUL client when this setting is true, the patron summary sidebar will collapse after a new patron sub-interface is selected.

In the web client the patron summary stays open, you must click on hide button to hide the summary

Revision history for this message
Bill Erickson (berick) wrote :

Confirmed the org unit setting "circ.auto_hide_patron_summary" is not referenced in the web client.

Changed in evergreen:
status: New → Confirmed
Katlyn Beck (klbeck)
Changed in evergreen:
assignee: nobody → Katlyn Beck (klbeck)
Revision history for this message
Katlyn Beck (klbeck) wrote :

I've abstracted out the functionality in toggle_expand_summary() into a controller function. This is called when the summary expand button is pressed as well when there is a change in the "toggle off patron summary" library setting.

The branch can be found at:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=3131f7151ddaab6e0a4e43fc196bb1903868d989

Changed in evergreen:
assignee: Katlyn Beck (klbeck) → nobody
tags: added: pull
tags: added: pullrequest
removed: pull
Revision history for this message
Katlyn Beck (klbeck) wrote :
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
milestone: none → 3.2.3
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Katlyn.

I have pushed a sign-off to your patch plus a follow-up commit to:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1717366-patron-summary-autocollapse

My commit treats "circ.auto_hide_patron_summary" as a plain org unit setting instead of a workstation setting for consistency with the XUL client. It also pre-caches the value at page resolve time for one less API call.

We could make this a "cascading" workstation setting, but that would require SQL seed data and that's arguably a separate LP ticket.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.2.3 → 3.3-beta1
Dan Wells (dbw2)
Changed in evergreen:
importance: Undecided → Low
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Changed in evergreen:
milestone: 3.3.3 → 3.3.4
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Changed in evergreen:
milestone: 3.3.5 → 3.4.2
Revision history for this message
Terran McCanna (tmccanna) wrote :

Please rebase against current master. Thanks!

tags: added: needsrepatch patron usability
Revision history for this message
Kyle Huckins (khuckins) wrote :

As Katlyn's not working on Evergreen anymore, I performed the rebase: user/khuckins/lp1717366-patron-summary-autocollapse-rebase

tags: removed: needsrepatch
Revision history for this message
Kyle Huckins (khuckins) wrote :
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.4.4
Changed in evergreen:
milestone: 3.4.4 → 3.5.1
Changed in evergreen:
milestone: 3.5.1 → 3.5.2
Revision history for this message
Terran McCanna (tmccanna) wrote :

In my testing, this change appears to do the opposite of what was intended. The first time I load a patron with this setting enabled, the summary bar is collapsed and then it stays open when I switch between the patron tabs.

tags: added: needsrepatch
Revision history for this message
Kyle Huckins (khuckins) wrote :

It appears to be working for me, but only with Hatch installed on my local machine

Changed in evergreen:
milestone: 3.5.2 → 3.6.1
tags: removed: pullrequest
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → none
tags: added: needswork
removed: needsrepatch
Revision history for this message
Donna Rowland (drowland) wrote : Re: [Bug 1717366] Re: Web client- LSE Toggle off the patron summary sidebar after first view

STOP

On Mon, Oct 25, 2021 at 12:07 PM Andrea Neiman <email address hidden>
wrote:

> ** Changed in: evergreen/3.5
> Status: Confirmed => Won't Fix
>
> --
> You received this bug notification because you are subscribed to
> Evergreen.
> https://bugs.launchpad.net/bugs/1717366
>
> Title:
> Web client- LSE Toggle off the patron summary sidebar after first
> view
>
> Status in Evergreen:
> Confirmed
> Status in Evergreen 3.2 series:
> Won't Fix
> Status in Evergreen 3.3 series:
> Won't Fix
> Status in Evergreen 3.4 series:
> Won't Fix
> Status in Evergreen 3.5 series:
> Won't Fix
>
> Bug description:
> Library Setting - Toggle off the patron summary sidebar after first
> view is not working in the web client.
>
> In XUL client when this setting is true, the patron summary sidebar
> will collapse after a new patron sub-interface is selected.
>
> In the web client the patron summary stays open, you must click on
> hide button to hide the summary
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1717366/+subscriptions
>
>

--

______________________________________________________________
Be careful when you follow the Masses....Sometimes the 'M' is silent.

Donna Rowland (<email address hidden>)

Finance Specialist

Fontana Regional Library

33 Fryemont Rd.

Bryson City, NC 28713

Voice: 828-488-2382 ext.124

Fax: 828-488-2638

“Opinions expressed in this message may not represent the policy of my
library. All e-mail sent to or from the Fontana Regional Library e-mail
systems is subject to monitoring and disclosure to third parties, including
law enforcement personnel.”

Gina Monti (gmonti90)
tags: added: circulation library-setting
tags: added: orgunitsettings
removed: library-setting
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers