Web client- LSE Toggle off the patron summary sidebar after first view

Bug #1717366 reported by Christine Burns on 2017-09-14
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned
3.2
Undecided
Unassigned

Bug Description

Library Setting - Toggle off the patron summary sidebar after first view is not working in the web client.

In XUL client when this setting is true, the patron summary sidebar will collapse after a new patron sub-interface is selected.

In the web client the patron summary stays open, you must click on hide button to hide the summary

Bill Erickson (berick) wrote :

Confirmed the org unit setting "circ.auto_hide_patron_summary" is not referenced in the web client.

Changed in evergreen:
status: New → Confirmed
Katlyn Beck (klbeck) on 2018-11-26
Changed in evergreen:
assignee: nobody → Katlyn Beck (klbeck)
Katlyn Beck (klbeck) wrote :

I've abstracted out the functionality in toggle_expand_summary() into a controller function. This is called when the summary expand button is pressed as well when there is a change in the "toggle off patron summary" library setting.

The branch can be found at:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=3131f7151ddaab6e0a4e43fc196bb1903868d989

Changed in evergreen:
assignee: Katlyn Beck (klbeck) → nobody
tags: added: pull
tags: added: pullrequest
removed: pull
Bill Erickson (berick) on 2019-01-15
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
milestone: none → 3.2.3
Bill Erickson (berick) wrote :

Thanks, Katlyn.

I have pushed a sign-off to your patch plus a follow-up commit to:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1717366-patron-summary-autocollapse

My commit treats "circ.auto_hide_patron_summary" as a plain org unit setting instead of a workstation setting for consistency with the XUL client. It also pre-caches the value at page resolve time for one less API call.

We could make this a "cascading" workstation setting, but that would require SQL seed data and that's arguably a separate LP ticket.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.2.3 → 3.3-beta1
Dan Wells (dbw2) on 2019-02-06
Changed in evergreen:
importance: Undecided → Low
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers