Web Client: library setting Record In-House Use: # of uses threshold for Are You Sure? dialog. is not honoured

Bug #1716962 reported by tji@sitka.bclibraries.ca on 2017-09-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

Tested on 2.12.X master about 3 weeks ago.

Galen Charlton (gmc) wrote :

Library setting in question is ui.circ.in_house_use.entry_cap; Open-ILS/web/js/ui/default/staff/circ/in_house_use/app.js does reference it but may not be working.

Changed in evergreen:
importance: Undecided → Medium
assignee: nobody → Cesar V (cesardv)
Bill Erickson (berick) wrote :

Hm, yeah, the input's numeric plus/minus controls stop at max, but don't prevent you from typing a value higher than the max.

Cesar V (cesardv) wrote :

Bill, I tested it and it seems that while one can manually type in a "number of uses" value greater than the max set in the permission ("Record In-House Use: Maximum # of uses allowed per entry"), it doesn't actually let you continue with the submit. I get a html5 form validation error tooltip, saying my number was higher than the max. See screenshot.

Regarding the "Are you sure?" dialogue I am actually not even seeing it pop up at all... but that could be that one cannot have that permission and the "max # of uses allowed per entry" permission at the same time? I'm not sure... I'll test further though

Cesar V (cesardv) wrote :
Cesar V (cesardv) wrote :

I don't actually see any code that would pop up any sort of dialogue, to warn/confirm that # of uses for the in-house use entry is higher than what settings allow... I do see a "countWarn" variable that was declared to take in the setting's value but was never used. I'll add some code to actually

Cesar V (cesardv) wrote :

.. do this. (finishing my thought form yesterday (: )

I've a fix for this here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1716962_inhouse_use_num_confirm_modal

Basically, ui.circ.in_house_use.entry_cap setting is taken care of by the form's validation, but ui.circ.in_house_use.entry_warn was being ignored. I added code to conditionally display a confirmation modal if this setting was triggered.

tags: added: pullrequest webstaffclient
Changed in evergreen:
assignee: Cesar V (cesardv) → nobody
Andrea Neiman (aneiman) on 2017-10-04
Changed in evergreen:
milestone: none → 3.0.1
Mike Rylander (mrylander) wrote :

3.0.1 will be better for having this commit. Thanks, Cesar!

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers