The authority linker doesn't work in the Z39.50 Edit then Import view or the Merge marc editor

Bug #1716479 reported by Jane Sandberg
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Jane Sandberg
3.6
Undecided
Unassigned

Bug Description

I've run into the following bug in the Evergreen 2.12 Web client.

Steps to reproduce:

1) Perform a z39.50 search
2) Select a record
3) Click Edit then Import
4) Click on the link next to any authorizable field.
5) You will see a mysteriously data-free heading: {{bibField.tag}} {{bibField.ind1}}{{bibField.ind2}}
6) Clicking on the "Immediately" and "Create and edit" buttons doesn't work.

Revision history for this message
Jane Sandberg (sandbej) wrote :
Revision history for this message
Jane Sandberg (sandbej) wrote :

Note: this bug also affects Webby.

Revision history for this message
Jane Sandberg (sandbej) wrote :

This is still happening in master as of today. Note that it also affects the merge interface in record buckets:

1) Create a record bucket and add some records to it.
2) Actions > Merge Records
3) Choose one record as lead record
4) Click Edit
5) Click the authority linker icon. Note that you get the same {{bibField.tag}} {{bibField.ind1}}{{bibField.ind2}} display, and the buttons don't work.

The problem is that cat/services/marcedit.js assumes that the relevant module has fetched the cat.marc_control_number_identifier library setting.

egCatalogApp is kind enough to do this, but egCatZ3950Search and egCatRecordBuckets don't.

Here is a branch to fix it: user/sandbergja/lp1716479_authority_linker_in_embedded_marc_editor

And here is a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1716479_authority_linker_in_embedded_marc_editor

tags: added: buckets pullrequest
summary: - spawnAuthorityLinker link icon doesn't work in the Z39.50 Edit then
- Import view
+ The authority linked doesn't work in the Z39.50 Edit then Import view or
+ the Merge marc editor
Jane Sandberg (sandbej)
summary: - The authority linked doesn't work in the Z39.50 Edit then Import view or
+ The authority linker doesn't work in the Z39.50 Edit then Import view or
the Merge marc editor
Revision history for this message
Michele Morgan (mmorgan) wrote :

Confirmed this behavior still exists in the 3.2.8 web client.

Changed in evergreen:
status: New → Confirmed
milestone: none → 3.4-beta2
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.4-beta2 → 3.4.1
Changed in evergreen:
milestone: 3.4.1 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.4.4
Changed in evergreen:
milestone: 3.4.4 → 3.5.2
Changed in evergreen:
milestone: 3.5.2 → 3.6.1
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
assignee: nobody → Jennifer Weston (jweston)
Revision history for this message
Jennifer Weston (jweston) wrote :

Tested during Feedback Fest using terran-testbox.gapines.org
Authority Linker is now working as expected.

Scenario #1)
Import record from Z39.50, choose Edit then Import -- was able to use link to authority search for author and create new authority record immediately before finishing the import; record saved and was imported successfully.

Scenario #2)
Merging three bib records from a record bucket -- was able to use link to authority search for a subject heading and create a new authority record; record was saved and merge was successfully completed.

I have tested this code and consent to signing off on it with my name, Jennifer Weston, and my email address, <email address hidden>

tags: added: signedoff
Changed in evergreen:
assignee: Jennifer Weston (jweston) → nobody
Revision history for this message
Beth Willis (willis-a) wrote :

I tested on Terran's https://terran-testbox.gapines.org/ server for both Z39.50 Edit then Import view and the Merge marc editor

--Z39.50 Edit then Import view--

I performed the following steps to test the Z39.50 Edit then Import View:

1) Performed a z39.50 search
2) Selected a record
3) Clicked "Edit then Import"
4) Clicked on the link next to a authorizable field.

The heading displayed correctly

5) Clicked on the "Immediately" button to create the authority record from the field; the subfield $0 was added to the heading display, as such:

650 0
‡a African Americans in motion pictures.
‡0 (Set cat.marc_control_number_identifier in Library Settings)112

6) Clicked "Save" to close the "Manage authority record links" display
7) Clicked to "Import" the bib record and it was imported as expected

Next I completed steps 1-4 above again; again, the heading displayed correctly

5) I clicked on the "Create and edit" button to create the authority record from the field;

6) I edited the record and clicked "Save"

The "Successfully created new record" toast displayed

7) I clicked "Use this authority"

8) I clicked "Save" to close the Manage authority record links" display

When I clicked to "Import" the bib record, nothing happened

--Merge MARC editor--

I performed the following steps to test the Merge MARC Editor

1) I created a record bucket and add some records to it.
2I I selected "Actions" > "Merge Records"
3) I chose one record as lead record
4) I clicked "Edit"
5) I click the authority linker icon. The heading displayed correctly

(Note: clicking "Edit using full editor" worked as well)

I was able to create new authority records using the "Immediately" and "Create and Edit" options

I believe that the editing and creation of authority records is working correctly but am hesitant to sign off on this bug due to the problem I found in importing the bib record when using the "Create and edit" option. Someone else may want to confirm whether they find the same thing.

Revision history for this message
Jennifer Weston (jweston) wrote :

I tested a little more after reading Beth's note.

I am seeing the same thing when I attempt to "Create and Edit" the authority record before Importing the bib record. I also noticed that the cat.marc_control_number_identifier is not set and the thesauri cannot be accessed so I wonder if the test db just doesn't have a full authorities config in place which could cause this kind of silent fail.

I would like to see this pullrequest included in 3.7.0 so we can have the ability to create new authorities immediately and then open a new ticket for additional findings.

Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
Revision history for this message
Jane Sandberg (sandbej) wrote :

Grabbing this to take a look at the issue Beth mentioned

Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbej)
Changed in evergreen:
milestone: 3.6.4 → 3.7.2
Elaine Hardy (ehardy)
tags: added: cat-authority
removed: authority
Elaine Hardy (ehardy)
tags: added: buckets-record
removed: buckets
no longer affects: evergreen/3.2
no longer affects: evergreen/3.3
no longer affects: evergreen/3.4
no longer affects: evergreen/3.5
Changed in evergreen:
milestone: 3.7.2 → 3.7.3
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers