Evergreen

Potential issue with action.all_circulation_slim definition

Bug #1714589 reported by Jason Boyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
Evergreen 3.0-beta

Bug Description

Eg 2.12.X to 3.0
The definition for the action.all_circulation_slim in upgrade script 1051 has potential issues when run against older databases. When using a UNION it's just assumed that the fields on either side of the union are in the same order, but over the years as upgrades are applied field order drifts and can't be relied on. It's fine to use the assumed order in union constructs in new databases but upgrade scripts should specify each field in the expected order. An update for this upgrade script is on its way.

See original description
Tags: pullrequest
Revision history for this message
Jason Boyer (jboyer) wrote :

As promised: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1714589_aacs_redefine

tags: added: pullrequest
description: updated
Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks, Jason. Good catch! Merged to master, and will backport to 2.12.

Revision history for this message
Mike Rylander (mrylander) wrote :

Or not, since the view is in rel_2_12.

Closing for great justice!

Changed in evergreen:
status: New → Fix Committed
milestone: 2.12.6 → 3.0-beta
Revision history for this message
Mike Rylander (mrylander) wrote :

Um... is NOT in.

Jason Boyer (jboyer)
description: updated
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.