web client: Retrieve patron action in holds pull list does not work

[Kathy Lussier]

I encountered this bug on a MassLNC VM and verified it on webby.

If you select the 'retrieve patron' action from the web client pull list, nothing happens. The following error message displays in the Console.

Error executing handler for "Retrieve Patron" => TypeError: item.hold.usr(...).id is not a function
TypeError: item.hold.usr(...).id is not a function
    at holds.js:543
    at Object.q [as forEach] (angular.min.js:7)
    at Object.service.show_patrons [as handler] (holds.js:540)
    at b.$scope.actionLauncher (grid.js:609)
    at fn (eval at compile (angular.min.js:236), <anonymous>:4:709)
    at b (angular.min.js:127)
    at e (angular.min.js:281)
    at b.$eval (angular.min.js:147)
    at b.$apply (angular.min.js:147)
    at HTMLAnchorElement.<anonymous> (angular.min.js:281)

[Andrea Neiman (aneiman)]

Confirmed in 3.0 beta, similar message in console.

[Andrea Neiman (aneiman)]

However, noting for workaround purposes, if you set the column "patron barcode" to display you can click on the barcode & retrieve the patron in question.

[Galen Charlton (gmc)]

A patch is available at the tip of the user/gmcharlt/lp1713764_fix_pull_list_retrieve_patron branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1713764_fix_pull_list_retrieve_patron

[Bill Erickson (berick)]

Confirmed and tested. Pushed to master. Thanks, Galen!