web client: Retrieve patron action in holds pull list does not work

Bug #1713764 reported by Kathy Lussier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

I encountered this bug on a MassLNC VM and verified it on webby.

If you select the 'retrieve patron' action from the web client pull list, nothing happens. The following error message displays in the Console.

Error executing handler for "Retrieve Patron" => TypeError: item.hold.usr(...).id is not a function
TypeError: item.hold.usr(...).id is not a function
    at holds.js:543
    at Object.q [as forEach] (angular.min.js:7)
    at Object.service.show_patrons [as handler] (holds.js:540)
    at b.$scope.actionLauncher (grid.js:609)
    at fn (eval at compile (angular.min.js:236), <anonymous>:4:709)
    at b (angular.min.js:127)
    at e (angular.min.js:281)
    at b.$eval (angular.min.js:147)
    at b.$apply (angular.min.js:147)
    at HTMLAnchorElement.<anonymous> (angular.min.js:281)

Revision history for this message
Andrea Neiman (aneiman) wrote :

Confirmed in 3.0 beta, similar message in console.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → 3.0-beta2
Revision history for this message
Andrea Neiman (aneiman) wrote :

However, noting for workaround purposes, if you set the column "patron barcode" to display you can click on the barcode & retrieve the patron in question.

tags: added: webstaffclient
Changed in evergreen:
milestone: 3.0-beta2 → 3.0-rc
Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available at the tip of the user/gmcharlt/lp1713764_fix_pull_list_retrieve_patron branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1713764_fix_pull_list_retrieve_patron

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
tags: added: regression
tags: added: pullrequest
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Confirmed and tested. Pushed to master. Thanks, Galen!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers