internal server error on viewing circ history

[Jason Etheridge]

egweb: template error: undef error - No field by the name circ_lib in Fieldmapper::action::user_circ_history! at /usr/local/share/perl/5.22.1/OpenILS/Utils/Fieldmapper.pm line 273.\n, referer: https://localhost/eg/opac/myopac/circs

This happens in master when you actually have at least one row in the history table for the user. It was introduced with the timezone work for LP#1705524

[Jason Etheridge (phasefx)]

bug 1705524 for linkiness

[Bill Erickson (berick)]

For active (non-aged) circulations, we could use the timezone of the circ_lib on the most recent circulation in the renewal chain. (Note usr_circ_history.source_circ points to the first circ in the chain).

Once the source circ chain is aged, we could fall back to server timezone (or patron home org unit timezone). Arguably, knowing the precise due date of a long-returned item is less important.

[Galen Charlton (gmc)]

A patch that takes up Bill's suggestion is available in the user/gmcharlt/lp1713160_unbreak_circ_history branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1713160_unbreak_circ_history

[Bill Erickson (berick)]

Error re-confirmed, patch applied, expected value is then displayed. Aged the circ in question and changed the time zone of the patron's home library and confirmed the due date displayed as expected.

Thanks Galen! Merged to master.