internal server error on viewing circ history

Bug #1713160 reported by Jason Etheridge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
High
Unassigned

Bug Description

egweb: template error: undef error - No field by the name circ_lib in Fieldmapper::action::user_circ_history! at /usr/local/share/perl/5.22.1/OpenILS/Utils/Fieldmapper.pm line 273.\n, referer: https://localhost/eg/opac/myopac/circs

This happens in master when you actually have at least one row in the history table for the user. It was introduced with the timezone work for LP#1705524

Revision history for this message
Jason Etheridge (phasefx) wrote :

bug 1705524 for linkiness

Changed in evergreen:
importance: Undecided → High
Revision history for this message
Bill Erickson (berick) wrote :

For active (non-aged) circulations, we could use the timezone of the circ_lib on the most recent circulation in the renewal chain. (Note usr_circ_history.source_circ points to the first circ in the chain).

Once the source circ chain is aged, we could fall back to server timezone (or patron home org unit timezone). Arguably, knowing the precise due date of a long-returned item is less important.

Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

A patch that takes up Bill's suggestion is available in the user/gmcharlt/lp1713160_unbreak_circ_history branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1713160_unbreak_circ_history

tags: added: opac pullrequest
Changed in evergreen:
status: New → Confirmed
milestone: none → 3.0-beta2
assignee: Galen Charlton (gmc) → nobody
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Error re-confirmed, patch applied, expected value is then displayed. Aged the circ in question and changed the time zone of the patron's home library and confirmed the due date displayed as expected.

Thanks Galen! Merged to master.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers