EDIReader unable to extract some vendcodes

Bug #1713138 reported by Bill Erickson on 2017-08-25
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.1
Undecided
Unassigned
3.2
Undecided
Unassigned

Bug Description

Evergreen 2.12

The EDI processing code is able to extract buyer account codes (acq.edi_account.vendcode) from EDI messages when they are appended to the SAN (NAD+BY+<san-value> <vendcode-value>::31B) or vendacct (NAD+BY+...::91) values. This is how B&T and possibly other vendors store vendcode data.

However, buyer account codes may also be stored in a separate field, RFF+API:<vendcode>, following the NAD+BY segment. This variation was seen in the wild w/ Midwest Library Service.

The end result is that inbound edi_messages (ORDRSP, INVOIC) fail to link to the correct edi_account.

EDIReader.pm should be taught to look for codes in the RFF+API and the EDI processing code that attempts to find the correct edi_account for each message should be taught to look at this value first, before attempting to extract the vendcode from the SAN value.

Bill Erickson (berick) on 2017-08-25
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1713138-edireader-vendcodes

I have confirmed the edi_reader.pl extracts the expected results when 0, 1, and 2 RFF+API fields are present. Live environment testing is next.

Also note the only other vendor I've seen that uses RFF+API is Brodart, and in that data they apply a shortened version of the buyer code (and are not also adding the vendcode to the SAN). Since vendcode values never prevent matches, and are only used to improve matches when possible, the code in my branch will be a no-op for Brodart.

Bill Erickson (berick) wrote :

We've been running this in production for a while. Adding pullrequest.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.0.2
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
milestone: 3.0.2 → 3.0.3
Changed in evergreen:
milestone: 3.0.3 → 3.0.4
Changed in evergreen:
milestone: 3.0.4 → 3.05
Changed in evergreen:
milestone: 3.0.5 → 3.0.6
Changed in evergreen:
milestone: 3.0.6 → 3.0.7
Changed in evergreen:
milestone: 3.0.7 → 3.0.8
Changed in evergreen:
milestone: 3.0.8 → 3.0.9
Changed in evergreen:
milestone: 3.0.9 → 3.0.10
Changed in evergreen:
milestone: 3.0.10 → 3.0.11
Changed in evergreen:
milestone: 3.0.11 → 3.0.12
Changed in evergreen:
milestone: 3.0.12 → 3.2.1
Changed in evergreen:
milestone: 3.2.1 → 3.2.2
Changed in evergreen:
milestone: 3.2.2 → 3.2.3
Changed in evergreen:
milestone: 3.2.3 → 3.3-beta1
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers