Item Price and Acq Cost fields are blank when editing an item

Bug #1713064 reported by Jason Boyer on 2017-08-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
High
Unassigned

Bug Description

Eg 2.12.5

When editing an item in the web client vol/copy editor, the price and acquisition cost fields will be blank regardless of the values in the database. This is because the input is of type "number" which is good but these fields are sent back and forth from the backend as strings and Angular is Very Picky about the types matching. This means you can save a new price or cost value, but you can't see their current values in the editor.

This can be fixed with a custom directive added to the module to format the model as expected but still store the value as a string. Branch coming soon.

Jason Boyer (jboyer) wrote :

The directive included in this branch can actually be reused elsewhere if need be; it accepts a precision attribute that defaults to 0 (no decimal places). It also makes an effort to not unintentionally set values that should be null to 0.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=f10de92a70e1f9ec99130399a964722ac0c7843f

tags: added: pullrequest
Jason Boyer (jboyer) on 2017-08-25
Changed in evergreen:
milestone: none → 3.0-alpha
Galen Charlton (gmc) on 2017-08-25
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Galen Charlton (gmc) wrote :

Pushed to master and rel_2_12. Thanks, Jason!

Changed in evergreen:
milestone: 3.0-alpha → 2.12.6
assignee: Galen Charlton (gmc) → nobody
status: New → Fix Committed
Jason Etheridge (phasefx) wrote :

Just for reference, the actual commit that got in:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=0d0e404f3bd0a357e1def316d1ab48fa4358b130

The previous link was for a different bug.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers