Ebook tabs always visible in My Account

Bug #1712840 reported by Terran McCanna
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
2.12
Fix Released
Low
Unassigned

Bug Description

The ebook tabs on the checkout and holds pages in My Account are always visible regardless of whether the ebook_api.enabled value is set to true or false. Looks like a small issue with the IF statement. Patch coming momentarily.

Revision history for this message
Terran McCanna (tmccanna) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
status: New → Confirmed
importance: Undecided → Low
milestone: none → 2.12.6
Revision history for this message
Galen Charlton (gmc) wrote :

Signed off and a follow-up patch written to cover the circ/holds history tabs. Branch is user/gmcharlt/lp1712840_signoff.

tags: added: signedoff
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks, Galen!

Revision history for this message
Ben Shum (bshum) wrote :

Looks good, fix pushed to master and backported to rel_2_12.

Changed in evergreen:
milestone: 2.12.6 → 3.0-alpha
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers