Patron merge does not transfer checkout history

[Bill Erickson]

Evergreen 2.10+ / Confirmed in 2.12.

With the move to a dedicated circulation history table (bug #1527342), merging patron accounts no longer carries the circulation history from the subordinate user to the lead user account. Instead, the history data stays linked to the (now) deleted user account.

To confirm:

1. Enable circ history tracking for 2 users (ideally 2 with same name for easy searching).
2. Check out items to both patrons
3. Load the 2 patrons in the patron search UI and merge one into the other.
4. action.usr_circ_history rows will remain unchanged and one set will still point to the deleted user.

[Bill Erickson (berick)]

Fix pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1712657-patron-merge-carries-checkouts

To test, follow confirmation steps above and confirm all action.usr_circ_history rows have a 'usr' value equal to the lead (merged-to) patron.

[Bill Erickson (berick)]

At time of writing the affected usr_merge() function is identical on 2.12 and 3.0, so one patch can apply to both.

[Jason Etheridge (phasefx)]

I'll open another bug for this, but for reference I ran into this error testing this:

egweb: template error: undef error - No field by the name circ_lib in Fieldmapper::action::user_circ_history! at /usr/local/share/perl/5.22.1/OpenILS/Utils/Fieldmapper.pm line 273.\n, referer: https://192.168.42.102/eg/opac/myopac/circs

[Jason Etheridge (phasefx)]

Looks good, thanks Bill! Pushed to master

[Jason Etheridge (phasefx)]

and pushed to rel_2_12