Web Client: Can Check Out with Due Date in the Past

[Terran McCanna]

In the 2.12.4 web client:

When checking out with the "specific due date" option, the interface does not prevent you from selecting a date in the past or at least giving a warning.

(In the xul client, the box around it turned red and would not let you complete the checkout.)

[Nathan Eady (mrmcquack)]

The ability to do this is actually useful for testing.

[Evergreen Bug Maintenance (bugmaster)]

Removing milestones for lack of pull request.

[Katlyn Beck (klbeck)]

I've resolved this issue with the following branch:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/klbeck/lp1712644-check-out-due-date

When trying to check out using a date in the past, the checkout input is disabled and an error will appear below the date-picker.

[Katlyn Beck (klbeck)]

I've fixed a minor thinko and amended my previous commit with a fix.
Now, when the date picker is open, past dates cannot be selected. When a past date is manually typed into the due date input box, the checkout input is disabled and an error will appear below the date-picker.

[Terran McCanna (tmccanna)]

Tested on 3.2.1 and it works well for us!

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

[Terran McCanna (tmccanna)]

Removing signoff because it causes an "input out of range" error on the patron registration / edit screen. (It doesn't stop it from saving on that screen, but shows an error.)

[Kyle Huckins (khuckins)]

The branch had the right general idea, but some things needed to be moved around a bit. I've made some changes and also added a year check to the outOfRange check(previously there was only a month and a day) and pushed up a branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/khuckins/lp1712644-check-out-due-date

[Dawn Dale (ddale)]

I was unable to test this fix on the bugsquash server.

[Dawn Dale (ddale)]

Sorry, last comment was posted to the wrong bug.

I have tested this code and consent to signing off on it with my name, Dawn Dale and my email address, <email address hidden>

[Bill Erickson (berick)]

Thanks, All. Regarding the implementation, I'm curious about the added year/month/date checks. Is the getTime() check not sufficient?

[Kyle Huckins (khuckins)]

We ran into an edge case where if you manually input a previous month or year without the additional checks, it would still allow you to submit. I originally assumed getTime would have done the trick as well, and I'm still not 100% sure why it didn't

[Kyle Huckins (khuckins)]

On further testing without the additional checks in egDatePicker, it seems to be working just fine only using getTime(). I've squashed both Katlyn's and I's on my collab branch, as all changes to the ui.js have been reverted by my commit.

[Galen Charlton (gmc)]

Upon testing, this needs a little more bullet-proofing:

[1] Go to the checkout page.
[2] Turn on the "Use Specific Date Until Logout" option.
[3] Type in a value that is out of range. The widget will indicate that and the barcode input will be disabled.

But...

[4] Switch to the Items Out tab, then back to the Checkout tab.
[5] The invalid date set in step #3 will be in effect, and you will be allowed to check out an item with the bogus date.

[Kyle Huckins (khuckins)]

Thanks Galen,

I've rebased the branch to master, and have been unable to replicate that issue - it looks like the Date Options aren't persisting when switching to Items Out and back, resetting the date selected in the datepicker and removing the outOfRange value.

[Kyle Huckins (khuckins)]

*Doh* Spoke too soon, I wasn't using the "Until logout" option. Investigating a fix...

[Kyle Huckins (khuckins)]

The branch has been rebased to latest master, and changes have been made to ensure the page is watching changes to the date input even when the input is seen as identical to what it was previously.

I've also ensured that incomplete date inputs(Think: 2019-0-01) won't break the UI by being saved to hatch.

[Terran McCanna (tmccanna)]

Tested and signed off with the New Devs Working Group. Sign off branch is here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1712644_due_date_in_past_signoff

[Galen Charlton (gmc)]

Pushed to master, rel_3_4, and rel_3_3. Thanks, Katlyn, Kyle, and Terran!