osrf_control --diagnostic should report max-children values

[Bill Erickson]

In addition to displaying the number of active drones per service, it would be helpful if osrf_control --diagnostic also displayed the maximum number of allowed drones per service.

Patch en route.

[Bill Erickson (berick)]

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/berick/lp1711194-osrf-control-diag-max-child

From the commit:

--diagnostic output shows the maximum number of allowed drones per service along with the active drone count. Additionally, a usage percentage value is displayed.

E.g.

$ /openils/bin/osrf_control -l --diagnostic

* open-ils.acq [1581] uptime=00:35 cputime=00:00:00 #drones=1/15 6%
* open-ils.actor [1629] uptime=00:35 cputime=00:00:00 #drones=2/15 13%

[Bill Erickson (berick)]

Just force-pushed a change to right-justify the percents display. Easier on the eyes.

[Chris Sharp (chrissharp123)]

Works as advertised:

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/csharp/lp1711194-osrf-control-diag-max-child

Thanks, Bill!

[Galen Charlton (gmc)]

I've tested and it does the thing, but it's a bit too easy to see ugly division by zero error messages. The user/gmcharlt/lp1711194-diag-improved branch has a signoff on the original patch as well as a follow-up; removing signoff tag for and requesting review of the follow-up.

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1711194-diag-improved

[Bill Erickson (berick)]

Good catch, thanks Galen. Tested and merged to master / rel_2_5.