Patron Notfication Preferences UI needs form validation
Bug #1711181 reported by
Chris Sharp
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Confirmed
|
Medium
|
Unassigned |
Bug Description
As described in bug 1098685, it's possible for a patron to enter an SMS notification number without selecting a carrier when placing a hold. It's also possible for a patron to enter a number without selecting a carrier in the Notification Preferences UI. The fix to bug 1098685 added form validation that prevents that in the hold placement dialog, and that same sort of fix would apply here nicely. The fix to bug 1710972 went part of the way there by making sure no default carrier was selected, but we still need some checking to prevent invalid data being entered.
Evergreen 2.11 through current master
OpenSRF 2.5.0/Master
PostgreSQL 9.5
Ubuntu 16.04
I'm not too familiar with the OPAC or its modperl back-end to much, but should there be some server-side code that also checks for the proper inputs, once posted to the server?