Patron Notfication Preferences UI needs form validation

Bug #1711181 reported by Chris Sharp
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

As described in bug 1098685, it's possible for a patron to enter an SMS notification number without selecting a carrier when placing a hold. It's also possible for a patron to enter a number without selecting a carrier in the Notification Preferences UI. The fix to bug 1098685 added form validation that prevents that in the hold placement dialog, and that same sort of fix would apply here nicely. The fix to bug 1710972 went part of the way there by making sure no default carrier was selected, but we still need some checking to prevent invalid data being entered.

Evergreen 2.11 through current master
OpenSRF 2.5.0/Master
PostgreSQL 9.5
Ubuntu 16.04

Revision history for this message
Cesar V (cesardv) wrote :

I'm not too familiar with the OPAC or its modperl back-end to much, but should there be some server-side code that also checks for the proper inputs, once posted to the server?

description: updated
Revision history for this message
Andrea Neiman (aneiman) wrote :

3.0 beta OPAC

Confirmed that the Notification Preferences in My Account will let you save an SMS number without entering a carrier.

Due to the fix in bug 1098685, an attempt to use this information at hold placement will prompt to enter missing information (i.e. the carrier).

Changed in evergreen:
status: New → Confirmed
Jane Sandberg (sandbej)
tags: added: opac
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers