Remaining chunk/bundle work

Bug #1710293 reported by Mike Rylander on 2017-08-11
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.1
Medium
Unassigned
3.2
Medium
Unassigned
3.3
Medium
Unassigned
3.4
Medium
Unassigned
3.5
Medium
Unassigned

Bug Description

Based on the following:

(master)$ gack max_chunk_count;gack 'max_chunk_size => 0'
Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm
1447: max_chunk_count => 1
1790: max_chunk_count => 1
1847: max_chunk_count => 1

Open-ILS/src/perlmods/lib/OpenILS/Application/Vandelay.pm
242: $client->max_chunk_count($self->{max_bundle_count}) if (!$client->can('max_bundle_count') && $self->{max_bundle_count});
806: $conn->max_chunk_count($self->{max_bundle_count}) if (!$conn->can('max_bundle_count') && $self->{max_bundle_count});
908: $conn->max_chunk_count(1) if (!$conn->can('max_bundle_size') && $conn->can('max_chunk_size') && $$args{report_all});
Open-ILS/src/perlmods/lib/OpenILS/Application/URLVerify.pm
38: max_chunk_size => 0,

Open-ILS/src/perlmods/lib/OpenILS/Application/HoldTargeter.pm
16: max_chunk_size => 0,

Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Z3950.pm
545: max_chunk_size => 0,

It looks like there are a couple places where we need to realign terminology, and we should probably do this for EG 3.0 since it will definitely require OpenSRF 2.5+ ... Specifically, I believe max_chunk_count needs to become max_bundle_count, and "max_chunk_size => 0" should become "max_bundle_count => 1" to have the desired effect.

I do not believe OpenSRF requires any change.

Revision history for this message
Mike Rylander (mrylander) wrote :

Note: This is unrelated to, but precipitated from initial investigation into, bug 1709710.

Changed in evergreen:
milestone: 3.0-beta → 3.0-beta2
Changed in evergreen:
milestone: 3.0-beta2 → 3.0-rc
Galen Charlton (gmc) on 2017-09-27
Changed in evergreen:
milestone: 3.0-rc → 3.0.1
Changed in evergreen:
milestone: 3.0.1 → 3.0.2
Changed in evergreen:
milestone: 3.0.2 → 3.0.3
Changed in evergreen:
milestone: 3.0.3 → 3.0.4
Changed in evergreen:
milestone: 3.0.4 → 3.05
Changed in evergreen:
milestone: 3.0.5 → 3.0.6
Changed in evergreen:
milestone: 3.0.6 → 3.0.7
Changed in evergreen:
milestone: 3.0.7 → 3.0.8
Changed in evergreen:
milestone: 3.0.8 → 3.0.9
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Here's a branch to implement these changes:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1710293_remaining_chunk_bundle_work

I have tested it lightly with no errors. I'd appreciate experienced eyes checking behind me.

tags: added: pullrequest
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Per Mike's recommendation I made some further removals of now-redundant code. Pushed to same branch.

Changed in evergreen:
milestone: 3.0.9 → 3.0.10
Changed in evergreen:
milestone: 3.0.10 → 3.0.11
Changed in evergreen:
milestone: 3.0.11 → 3.0.12
Changed in evergreen:
milestone: 3.0.12 → 3.2.0
Changed in evergreen:
milestone: 3.2.0 → 3.2.1
Changed in evergreen:
milestone: 3.2.1 → 3.2.2
Changed in evergreen:
milestone: 3.2.2 → 3.2.3
Changed in evergreen:
milestone: 3.2.3 → 3.3-beta1
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Changed in evergreen:
milestone: 3.3.3 → 3.3.4
Changed in evergreen:
milestone: 3.3.4 → 3.3.5
Changed in evergreen:
milestone: 3.3.5 → 3.4.2
Changed in evergreen:
milestone: 3.4.2 → 3.4.3
Changed in evergreen:
milestone: 3.4.3 → 3.4.4
Changed in evergreen:
milestone: 3.4.4 → 3.5.1
Galen Charlton (gmc) on 2020-08-12
Changed in evergreen:
milestone: 3.5.1 → 3.5.2
Revision history for this message
Chris Sharp (chrissharp123) wrote :
Changed in evergreen:
milestone: 3.5.2 → 3.6.1
tags: added: cleanup
Changed in evergreen:
milestone: 3.6.1 → 3.6.2
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Changed in evergreen:
milestone: 3.6.3 → 3.6.4
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers