db-seed-i18n.py can miss strings

Bug #1709932 reported by Galen Charlton on 2017-08-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

db-seed-i18n.py can crash with an error like this:

  Error in oils_i18n_gettext line 16655 of SQL source file: Cannot parse the source. Empty strings in there?

When this happens, any potential strings after the line in question are not included in the POT file.

This ultimately stems from it not recognizing patterns like this, where the commas between columns are used before the strings, not afterwards:

    ,oils_i18n_gettext(
         'webstaff.cat.label.font.family'
        ,'Item Print Label Font Family'
        ,'coust'
        ,'label'
    )

Evergreen master

Galen Charlton (gmc) on 2017-08-10
Changed in evergreen:
importance: Undecided → Medium
milestone: none → 3.0-alpha
tags: added: i18
Galen Charlton (gmc) wrote :

A patch is available at the tip of the user/gmcharlt/lp1709932_improve_db_seed_i18n branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1709932_improve_db_seed_i18n

tags: added: i18n pullrequest
removed: i18
Galen Charlton (gmc) wrote :

Thanks for testing, Chris! Merged to master to clear the way to cleaning merging some of the other i18n patches.

Changed in evergreen:
status: New → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers