Web Staff Client: Reports description field required

Bug #1709698 reported by Terran McCanna on 2017-08-09
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned

Bug Description

Tested as of 2.12.2

When creating a new report template, I cannot save it without entering something into the description field. I don't see why that would be a required field.

Mike Rylander (mrylander) wrote :

The description field on reporter.template has actually always been marked NOT NULL. IIRC, the intention was to strongly encourage staff to enter a meaningful description of the report, and (also IIRC) the decision on that didn't come from the developers.

There are several ways we could address this: make the field NULLABLE in the database; default it to and empty string instead of undefined in the UI; mark it as required and have the form complain and refuse to submit (which would address any post-save failure caused by this requirement, if that's possible today -- I don't recall).

Are there broader thoughts from the community?

Kathy Lussier (klussier) on 2017-08-28
Changed in evergreen:
status: New → Confirmed
Kathy Lussier (klussier) wrote :

In the xul client, we are able to save a template without adding a description. Is this because the xul client was defaulting to an empty string in that field?

Mike, currently I think the web client is behaving as you described in the 2nd option. The save button is disabled until something is entered in the description field.

We almost always include a description in our templates, but I don't see a reason why we should force that on a user.

A mild +1 to defaulting to either making the field NULLABLE or defaulting to an empty string.

Rogan Hamby (rogan-hamby) wrote :

HEAD:user/rogan/lp1709698_template_description_should_be_nullable

tags: added: pullrequest
Rogan Hamby (rogan-hamby) wrote :

Removing pullrequest. Some issues were found that need to be addressed in how the information ends up passing to the report interface.

tags: removed: pullrequest
Changed in evergreen:
assignee: nobody → Rogan Hamby (rogan-hamby)
Changed in evergreen:
assignee: Rogan Hamby (rogan-hamby) → nobody
Jessica Woolford (jwoolford) wrote :

I have tested this code and consent to signing off with my name, Jessica Woolford, and email address, <email address hidden>.

tags: added: signedoff
Chris Sharp (chrissharp123) wrote :

Committed to master. Thanks, Rogan and Jessica!

Changed in evergreen:
status: Confirmed → Fix Committed
milestone: none → 3.next
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers