libopensrf build fails with -j > 1

Bug #1704116 reported by Graham Billiau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSRF
Fix Released
Low
Unassigned
2.4
Fix Committed
Low
Unassigned

Bug Description

The Makefile doesnt specify that osrf_json_test depends on libopensrf. As such the build may fail when run in parallel.

Tags: pullrequest
Revision history for this message
Graham Billiau (gbilliau) wrote :
Revision history for this message
Galen Charlton (gmc) wrote :

Thanks for this patch (and the others). We'll try them out, and I'm glad to see somebody working on expanding the list of supported platforms.

As an administrative matter, could you indicate whether you accept Evergreen's and OpenSRF's DCO? See

https://wiki.evergreen-ils.org/doku.php?id=contributing#developer_s_certificate_of_origin

and

https://wiki.evergreen-ils.org/doku.php?id=dev:standing_dco

Galen Charlton (gmc)
Changed in opensrf:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 2.5.1
Revision history for this message
Dan Scott (denials) wrote :

Pedant here: it's not "accepting" the DCO; it's "affirming" the DCO (stating that the contribution is your own work or that you have the right to submit the work).

I mention this only because some other projects require people to "accept" a contributor license agreement that can include egregious demands like assigning copyright to the project, etc... the DCO is much more agreeable than that :)

Pedantry over. Welcome, Graham! Happy to have you contributing to the project!

Revision history for this message
Galen Charlton (gmc) wrote :

The patch in Git form (and tested by me) is available in the working/OpenSRF repository at the tip of the user/gmcharlt/lp1704116_parallel_build branch:

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1704116_parallel_build

To whoever does the final testing, I note that the patch is structured to anticipate Graham's affirmation of the DCO, and should not be merged until Graham explicitly affirms it for himself.

tags: added: pullrequest
Revision history for this message
Graham Billiau (gbilliau) wrote :

I hearby affirm the OpenSRF/Evergreen Developer's Certificate of Origin v1.1 .

Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_2_5, and rel_2_4. Thanks, Graham!

Changed in opensrf:
status: Confirmed → Fix Committed
Changed in opensrf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.