make install doesn't respect DESTDIR

Bug #1704090 reported by Graham Billiau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenSRF
Fix Released
Low
Unassigned

Bug Description

There are two points where make install installs files outside of $DESTDIR. I've attached a patch which corrects this.

I'm sure the first chunk won't break anything, but you may not want to apply the second chunk to the main tree. The installation process is complicated enough already and it would add an extra step.

This is just the first of several problems I've noticed while creating Gentoo packages for OpenSRF and Evergreen. Should you choose not to apply this patch I'll continue to maintain it as part of the Gentoo packages (it won't install without these patches).

Tags: pullrequest
Revision history for this message
Graham Billiau (gbilliau) wrote :
Revision history for this message
Galen Charlton (gmc) wrote :

Thanks. Upon glancing at it, I see what you mean about that second chunk; I'm inclined to spin off the question of installing and activating the Apache modules in a more cross-platform way into a separate bug report.

Changed in opensrf:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 2.5.1
Revision history for this message
Galen Charlton (gmc) wrote :

I've pushed a version of the patch to the working/OpenSRF repository that I believe handles the apxs2 stuff in a way to keep both packagers and folks installing from the tarball happy:

http://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1704090_destdir

Graham, please let me know if this approach would work for you.

tags: added: pullrequest
Revision history for this message
Graham Billiau (gbilliau) wrote :

That's a good solution. It meets Gentoo's needs and doesn't make things harder for normal people.

Revision history for this message
Galen Charlton (gmc) wrote :

Thanks for the feedback. I've gone ahead and merged the revised patch to master and rel_2_5.

no longer affects: opensrf/2.4
Changed in opensrf:
status: Confirmed → Fix Committed
Changed in opensrf:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.