memcache keys containing % fail
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
High
|
Unassigned | ||
OpenSRF |
Fix Released
|
High
|
Unassigned | ||
3.0 |
Fix Released
|
High
|
Unassigned |
Bug Description
In src/libopensrf/
This can happen if a username or barcode contains a '%', and a user attempts to log in (using the open-ils.auth service, and thus the C functions in question).
Is there any institutional memory regarding why we're using VA_LIST_TO_STRING at all? Should we not just use the key directly via _clean_key()?
Changed in evergreen: | |
milestone: | none → 3.0-beta2 |
milestone: | 3.0-beta2 → 3.next |
Changed in opensrf: | |
milestone: | none → 3.0.2 |
milestone: | 3.0.2 → 3.1-beta |
Changed in evergreen: | |
assignee: | Jason Stephenson (jstephenson) → nobody |
Changed in opensrf: | |
assignee: | Jason Stephenson (jstephenson) → nobody |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
Changed in opensrf: | |
status: | Fix Committed → Fix Released |
IIRC, it was purely for convenience. Looks like it was never used, though. +1 to dropping the variable args entirely and just passing the key to _clean_key().