Remove opt-in setting from opensrf.xml

[Jeff Davis]

In all versions of EG including master, opt-in functionality is governed by a setting in opensrf.xml. This is kind of a pain; for example, you have to manually edit opensrf.xml to enable the feature for testing. It would be sensible to move this to an in-database org setting. Better yet, perhaps we can simply check if any of the existing opt-in-related org settings are applied at the context org.

[Jeff Davis (jdavis-sitka)]

Here's a work-in-progress branch that replaces the opensrf.xml setting with a global flag: user/jeffdavis/lp1699611-db-optin / https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1699611-db-optin

It's a global flag rather than a library setting because the existing setting is global, and doing it this way preserves existing functionality while minimizing the changes to the codebase.

[Jeff Davis (jdavis-sitka)]

OK, I think this branch is working (and live test 15-lp1533329-opt-in.t passes), so I'm adding a pullrequest.

[Jeff Davis (jdavis-sitka)]

Here's a test plan for a server with Concerto data:

(1) Enable the circ.user_opt_in global flag.

(2) Configure library settings for opt-in. The following should work for our purposes:

At CONS, set org.patron_opt_default to 1.
At SYS1, set org.patron_opt_boundary to 1.
At SYS2, set org.patron_opt_boundary to 1.
At BR4, set org.restrict_opt_to_depth to 1.

(3) Login to the staff client with BR1 as your working location.

(4) Retrieve a BR1 patron (99999350419). There should be no opt-in prompt.

(5) Retrieve a BR2 patron (99999360638). There should be no opt-in prompt.

(6) Retrieve a BR3 patron (99999378730). You should see a prompt asking if the patron consents to having their personal information shared with your library (assuming your test patron hasn't previously been opted-in at your working location). Click Cancel.

(7) Retrieve a BR4 patron (99999373186). You should see a message that says "This patron's record is not viewable at your library."

(8) Disable the circ.user_opt_in global flag and repeat steps 4-7. You should be able to retrieve all patrons without any opt-in related prompts or messages.