web client: attempting to update a MARC record without required permissions fails without feedback to the user

Bug #1693580 reported by Kathy Lussier on 2017-05-25
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Undecided
Unassigned
3.1
Undecided
Unassigned

Bug Description

Tested on 2.12

If a user account does not have the UPDATE_MARC permission and attempts to perform an edit on the record, the update action will fail without any feedback to the user. In the XUL client, the user will receive an error message at the point that the user tries to save the record.

Ideally, the user will receive a message as soon as they click the MARC Edit tab to prevent them from making a long series of edits that ultimately fail. However, for feature parity with the xul client, at a minimum an error message should pop up when they click Save.

Kathy Lussier (klussier) on 2017-08-03
tags: added: silentfailure
Andrea Neiman (aneiman) on 2018-04-30
tags: added: cataloging
Laura Sachjen (sachjenl) on 2018-05-22
Changed in evergreen:
status: New → Confirmed
Michele Morgan (mmorgan) wrote :

Related: bug 1716765

Bill Erickson (berick) wrote :

I tracked the failure to report to the user back to bug #1808016. However, the bug could also be avoided by checking permissions in advance, when the page first loads.

Bill Erickson (berick) wrote :

Additionally the MARC editor should probably use the 'open-ils.cat' API's since they have additional smarts baked in for handling TCN collisions, etc. This would also resolve the silent-failure permission issue.

Bill Erickson (berick) wrote :

Marked bug #1716765 as a duplicate.

Plan is to migrate to using open-ils.cat APIs and to add notifications (toasts) on save/create/delete success or failure.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

Fixes pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1693580-marc-editor-api-notify

Note there are 2 commits. One fixes some Perl API bugs, the other applies the UI changes.

    1. Indicate in the interface when a bib/auth MARC record edit failed or
    succeeded.

    2. Handle permission failures on MARC edit by displaying the permission
    override dialog.

tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
milestone: none → 3.1.11
milestone: 3.1.11 → 3.2.5
Changed in evergreen:
milestone: 3.2.5 → 3.2.6
Bill Ott (bott) wrote :

After applying this, attempting to undelete a title fails. I'm unsure if there's any relation, but wondered if anyone else could replicate the issue, before I started chasing red herrings.

Bill Ott (bott) wrote :

I can verify that this had nothing to do with the undelete issue.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers