Action trigger validators problems for Long Overdue items

[Michele Morgan]

For systems using the Mark Item Long Overdue action trigger, the current validators allow subsequent overdue notices to be sent to a patron whose long overdue item has been paid for. Once a long overdue item is paid, the transaction is closed and the patron should no longer receive overdue notices.

None of the current validators consult action.circulation.xact_finish, which is what's needed when additional notifications are sent to patrons with long overdue items.

[Michele Morgan (mmorgan)]

Working branch is at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1692116_a/t_validator_fix_for_paid_long_overdue_items

The patch changes the CircIsOpen validator to check that there is no xact_finish date in the action.circulation row.

Testing plan:

1. Identify or create a Long Overdue item.
2. Identify or create a trigger to send a notification for the Long Overdue item with the following parameters:
   - Hook: checkout.due
   - Validator: CircIsOpen
   - Event Repeatability Delay: Short enough to run again for the same target
3. Run the action trigger to confirm that a notification is created for the Long Overdue item
4. Pay the bill for the Long Overdue item
5. Confirm that the action.circulation.xact_finish is no longer null
6. Run the action trigger again
7. Observe that a notification is generated for the item despite the transaction being finished
8. Apply the patch
9. Run the action trigger again
10. Observe that the event created is now invalid

[Chris Sharp (chrissharp123)]

Signing off on this and pushing to master, rel_3_0, and rel_3_1.

Thanks, Michele!