Webstaff support for globally null-ifying an audio notification

Bug #1691860 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

Evergreen circ 2.12

The browser client supports a variety of audio alerts. Since each alert can be configured to use its own wav file, disabling a specific alert on the server (i.e. for all users) is as simple as configuring a specific alert to use a wav file that makes no sound.

While we will likely have more fine-grained user configuration for which alerts to play over time, I think it would be useful to include a 'nosound.wav' file in the repository so admins have the option of squashing specific types of alerts for all users on the server. It's also useful for development where you may want to disable certain repetitive sounds, but not all sounds.

For example, to use nosound.wav to silence the patron search success alert:

mkdir -p /openils/var/web/audio/notifications/success/patron/
cd /openils/var/web/audio/notifications/success/patron/
ln -s ../../nosound.wav by_search.wav # or just copy it

Patch en route.

Revision history for this message
Bill Erickson (berick) wrote :

nosound.wav file created and pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1691860-nosound-notification

File was created (by me) via 'arecord < /dev/zero > nosound.wav' with a sub-second duration.

As noted in the commit:

To test:

[1] mkdir -p /openils/var/web/audio/notifications/success/patron/
[2] cd /openils/var/web/audio/notifications/success/patron/
[3] ln -s ../../nosound.wav by_search.wav
[4] Perform a patron search in the browser client and confirm no sound is played upon successful search.

If patron searches have recently been performed, step 4 may require a cache clear, a different tab, browser restart, eye of newt.

Once confirmed, remove the symlink to recover the original alert sound.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.0-alpha
Revision history for this message
Terran McCanna (tmccanna) wrote :

I'll test this fix during bug squashing week.

Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks, Bill!

I have tested this code and consent to signing off on it with my name, Terran McCanna and my email address, <email address hidden>.

Changed in evergreen:
status: New → Confirmed
tags: added: signedoff
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
Kathy Lussier (klussier)
Changed in evergreen:
assignee: nobody → Kathy Lussier (klussier)
Revision history for this message
Kathy Lussier (klussier) wrote :

Thank you Bill and Terran! I created a small release notes entry for this one and merged the branch to master for inclusion in 3.0.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Kathy Lussier (klussier) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
tags: added: ux-sounds
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.