Webstaff grid "Configure Columns" interface should support moving columns

Bug #1691801 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Wishlist. Evergreen circa 2.12.

The webby grid supports moving columns via drag-and-drop, but this operation is finicky and does not always behave as one might expect. It would be useful to support moving columns via the "Configure Columns" interface, much like the column resize options.

Options should include moving a column left by one, right by one, and potentially moving a column all the way to the left (and right?), though that may depend on the amount screen real estate required for the action links.

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Code pushed.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1691801-webby-grid-move-cols

Adds support for moving a column left one, right one, all the way left, and all the way right. The most recently modified column is styled to make it easier for the user to track the movement of the column. Also changes the expand/collapse links to use the expand glyphicons.

Changed in evergreen:
milestone: none → 3.0-alpha
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Spotted an issue, pushing a fix...

tags: removed: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Issue resolved and squashed.

tags: added: pullrequest
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
status: New → Confirmed
Revision history for this message
Galen Charlton (gmc) wrote :

I like the idea, and I see an added bonus in the shape of this making it possible to modify column position using only the keyboard. However, push to extreme right isn't quite there yet, as evidenced by trying it in the patron search results grid, where (say) moving ID to the extreme right just ends up moving it four columns over. I suspect it has to do with calculating the proper index when there are a bunch of hidden columns.

tags: added: needsrepatch
removed: pullrequest
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

But otherwise, moving left and right and to the extreme left worked for me, and I verified that the column order persisted.

Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Galen. I'll take a look.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Fix pushed and squashed into the original commit. Push far-right should now work regardless of hidden columns.

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Tested and signed off: user/gmcharlt/lp1691801_signoff

I note that keyboard navigation isn't quite as good as I initially thought, at least in Chrome. If you move a column rightward, focus stays with the button that you just used, but if you move a column left, it doesn't stay with the button, and instead moves to the column to the right of the original column.

tags: added: pullrequest signedoff
removed: needsrepatch
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master. Thanks, Bill!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.