webstaff: protect more modals from accidental closures

Bug #1689325 reported by Galen Charlton on 2017-05-08
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

By default, Bootstrap modals are dismissed if the user clicks outside of them. Sometimes, that's OK; if the modal is only providing some sort of information message, providing lots of ways to get rid of it can be handy.

More often (?), though, we don't want that behavior, as accidentally dismissing the modal can result in losing work — for example, consider a modal that embeds the MARC editor.

We should consider adding the "backdrop: 'static'" option as a matter of course to all modals.

Evergreen master

Galen Charlton (gmc) on 2017-05-08
Changed in evergreen:
importance: Undecided → Wishlist
milestone: none → 3.next
summary: - webstaff: protect more modals against accidental closures
+ webstaff: protect more modals from accidental closures
Andrea Neiman (aneiman) on 2017-05-08
tags: added: webstaffclient
Cesar V (cesardv) on 2017-10-09
Changed in evergreen:
assignee: nobody → Cesar V (cesardv)
Cesar V (cesardv) wrote :

I have a working branch for this here...


Still working on testing every modal, making sure the new setting won't causes usability/UI issues.

Cesar V (cesardv) wrote :

So far, I've run into (and fixed) a bug 1722899 (which was exacerbated by the changes to the modals here.)

Perhaps a better approach (if we feel necessary) in order to thoroughly test this would be to generate a shared spreadsheet of all the affected modals and spread the testing among a couple of volunteers.

Might be overkill to test this way, however, yet it might help identify perhaps which modals would benefit from being able to be dismissed by clicking outside of it (in the backdrop).

Changed in evergreen:
assignee: Cesar V (cesardv) → nobody
tags: added: pullrequest
Mike Rylander (mrylander) wrote :

Picked into master for broader testing and refinement. Thanks, Cesar!

Changed in evergreen:
status: New → Fix Committed
Galen Charlton (gmc) on 2017-11-09
Changed in evergreen:
milestone: 3.next → 3.1-beta
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers