Some inline styles in OPAC should be replaced for RTL locales

Bug #1687031 reported by Galen Charlton
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Medium
Unassigned

Bug Description

git-grep shows that there are some inline styles left in the OPAC that likely need to be made RTL-aware:

~/Evergreen/Open-ILS/src/templates/opac$ git grep 'style="'|grep -P '(left|right)'
myopac/circ_history.tt2: <td style="padding-left:9px;">
myopac/circ_history.tt2: <td style="padding-left:5px;">
myopac/circs.tt2: <span style="padding-left:9px;">
myopac/circs.tt2: <span style="padding-left:5px;">
myopac/hold_history.tt2: <span style="float:left;">[% l("Previously Held Items") %]</span>
myopac/hold_history.tt2: <span style="float:right;">
myopac/holds.tt2: <span id="acct_holds_header" style="float:left;">
myopac/holds.tt2: <td style="padding-left:9px;">
myopac/holds.tt2: <td style="padding-left:5px;">
myopac/holds.tt2: <td style="padding-left:5px;" class='error'>
myopac/lists.tt2: <span class="float-left" style="padding-left:34px;">[% l('Navigate Selected List ') %]</span>
myopac/messages/list.tt2: <span id="acct_messages_header" style="float:left;">[% l("Messages") %]</div>
myopac/messages/list.tt2: <span style="padding-left:9px;">
myopac/messages/list.tt2: <span style="padding-left:5px;">
myopac/messages/single_message.tt2: <span id="acct_messages_header" style="float:left;">[% l("Message") %]</div>
myopac/messages/single_message.tt2: <span style="padding-left:9px;">

Evergreen master

Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Medium
tags: added: i18n opac rtl
Changed in evergreen:
assignee: nobody → Stephanie Leary (stephanieleary)
Changed in evergreen:
assignee: Stephanie Leary (stephanieleary) → nobody
status: New → Confirmed
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

We don't have very many of these left in the Bootstrap OPAC. However, we also need to add dir="rtl" to the HTML tag itself if we want RTL to work correctly.

Small branch to clean up the remaining inline styles and set the direction:
user/sleary/opac/LP1687031-inline-left-right-styles

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/opac/LP1687031-inline-left-right-styles

Note for testers: you will not see the dir attribute at all unless your locale specifies RTL. For testing purposes, if you want to verify that the attribute is being added, you can change the new HTML tag to include an ELSE:

[% IF ctx.get_i18n_l(ctx.eg_locale).rtl == 't' %] dir="rtl" [% ELSE %] dir="" [% END %]

tags: added: pullrequest
removed: rtl
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.15.1
Changed in evergreen:
milestone: 3.15.1 → 3.15.2
Changed in evergreen:
milestone: 3.15.2 → 3.15.3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.