web client: bad barcode image is missing

Bug #1683555 reported by Kathy Lussier on 2017-04-18
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Low
Unassigned

Bug Description

The bad barcode dialog in the web client tries to display bad_barcode.png in the images directory. However, there is no bad_barcode.png image in that directory, so an empty image displays. We'll either need to move the bad_barcode image to the images directory or, if it's located somewhere else, change the link in the bad barcode dialog.

Changed in evergreen:
milestone: 3.0-alpha → none
Galen Charlton (gmc) on 2017-04-26
Changed in evergreen:
milestone: none → 2.12.2
no longer affects: evergreen/2.12
Changed in evergreen:
milestone: 2.12.2 → 2.12.3
Changed in evergreen:
milestone: 2.12.3 → 2.12.4
Michele Morgan (mmorgan) on 2017-07-17
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Michele Morgan (mmorgan) wrote :

Working branch is available at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1683555_restore_bad_barcode_image

This copies the existing bad_barcode.png file to web/images and also makes a few tweaks to the text and style of the dialog box. Attaching a screenshot of the reworked dialog box.

Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
tags: added: pull
tags: added: pullrequest
removed: pull
Changed in evergreen:
assignee: nobody → Josh Stompro (u-launchpad-stompro-org)

Signoff branch at - user/stompro/lp1683555_restore_bad_barcode_image_signoff
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1683555_restore_bad_barcode_image_signoff

I tested this with a 7/18/2017 version of master. The bad barcode image now shows up when I test in checkout and check-in with the strict barcode box checked.

When I try to test in Item Status I find that there is no strict barcode checkbox so I cannot trigger the popup. I think that is a separate issue though.

Josh

Changed in evergreen:
status: New → Confirmed
assignee: Josh Stompro (u-launchpad-stompro-org) → nobody
tags: added: signedoff
Galen Charlton (gmc) on 2017-07-24
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Galen Charlton (gmc) wrote :

Pushed to master and rel_2_12. Thanks, Michele and Josh!

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers