fm_IDL reporter::xact_billing_totals incorrect column type

Bug #1681930 reported by Blake GH on 2017-04-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.1
Medium
Unassigned
3.2
Medium
Unassigned
3.3
Undecided
Unassigned

Bug Description

I discovered a value of "int" for "unvoided"
<field reporter:label="Unvoided Billing Amount" name="unvoided" reporter:datatype="int" />

The view puts the total unvoided sum of money* into that column:
sum(
        CASE
            WHEN b.voided THEN 0::numeric
            ELSE b.amount
        END) AS unvoided,

The datatype should be "money"

The same bug exists in reporter::xact_paid_totals

This affects reports

Blake GH (bmagic) on 2017-04-11
description: updated
Jane Sandberg (sandbej) on 2019-01-19
tags: added: billing bitesize reports
Geoff Sams (gsams) wrote :

While looking into this, I found that xact_paid_total also had the incorrect type of int for unvoided amount, and corrected it as well.

working branch can be found here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gsams/LP1681930_xact_billing_totals_incorrect_column_type

Changed in evergreen:
status: New → Confirmed
tags: added: pullrequest
Michele Morgan (mmorgan) on 2019-03-07
Changed in evergreen:
milestone: none → 3.3-rc
Changed in evergreen:
milestone: 3.3-rc → 3.3.1
Rogan Hamby (rogan-hamby) wrote :

worked for me. sign off at: user/rogan/lp1681930_signoff

tags: added: signedoff
Changed in evergreen:
milestone: 3.3.1 → 3.3.2
Galen Charlton (gmc) on 2019-05-23
Changed in evergreen:
importance: Undecided → Medium
Changed in evergreen:
milestone: 3.3.2 → 3.3.3
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_3, rel_3_2, and rel_3_1. Thanks, Geoff and Rogan!

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
milestone: 3.3.3 → 3.4-beta1
Galen Charlton (gmc) on 2019-09-11
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers