webstaff: crash when attempting to open opt-in confirmation modal

Bug #1681466 reported by Galen Charlton
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned

Bug Description

When performing a patron barcode search in the web staff client and opt-in is required, the dialog that is supposed to confirm whether the patron is permitting opting in to the foreign fails to load with the following error:

angular.js:14199 TypeError: Cannot read property 'length' of undefined
    at k (angular.js:12592)
    at new service.open.$uibModal.open.controller (ui.js:254)
    at Object.invoke (angular.js:4771)
    at R.instance (angular.js:10592)
    at ui-bootstrap-tpls.min.js:8
    at angular.js:16696
    at m.$eval (angular.js:17994)
    at m.$digest (angular.js:17808)
    at angular.js:18033
    at f (angular.js:6045)
    at angular.js:6324

The immediate cause is that the egCore.strings.OPT_IN_DIALOG string around line 800 of circ/patron/app.js is not defined anywhere.

Evergreen 2.12+

Galen Charlton (gmc)
Changed in evergreen:
milestone: none → 2.12.1
importance: Undecided → Medium
Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Pushed a fix to working/user/jeffdavis/lp1681466-opt-in-dialog:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=c19f36c3

tags: added: pullrequest webstaffclient
tags: added: optin
Revision history for this message
Galen Charlton (gmc) wrote :

Thanks, Jeff! I've signed off on your patch and added a followup that adds test instructions as well as a title for the dialog. The signoff branch is user/gmcharlt/lp1681466_signoff.

tags: added: signedoff
Changed in evergreen:
milestone: 2.12.1 → 2.12.2
Revision history for this message
Bill Erickson (berick) wrote :

Confirmed, tested, and merged to master/rel_2_12. Thanks Jeff, thanks Galen.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
status: New → Confirmed
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers