Remove open-ils.permacrud service

Bug #1680566 reported by Galen Charlton
This bug affects 2 people
Affects Status Importance Assigned to Milestone

Bug Description

As Dan Wells noted during a presentation at the 2017 conference, the open-ils.permacrud service was effectively deprecated by the advent of open-ils.pcrud. Consequently, the last few invocations of it should be changed to use open-ils.pcrud and the open-ils.permacrud service removed.

Grep tells us:

Open-ILS/web/js/dojo/openils/widget/TranslatorPopup.js:223: OpenSRF.CachedClientSession('open-ils.permacrud').request({
Open-ILS/web/js/dojo/openils/widget/TranslatorPopup.js:224: method : 'open-ils.permacrud.' + method + '.i18n',
Open-ILS/web/js/ui/default/vandelay/vandelay.js:175: ['open-ils.permacrud', ''],
Open-ILS/web/js/ui/default/vandelay/vandelay.js:288: ['open-ils.permacrud', ''],
Open-ILS/web/js/ui/default/vandelay/vandelay.js:314: ['open-ils.permacrud', ''],
Open-ILS/web/js/ui/default/vandelay/vandelay.js:1752: var method = 'open-ils.permacrud.update.' + rec.classname;
Open-ILS/web/js/ui/default/vandelay/vandelay.js:1755: ['open-ils.permacrud', method],
Open-ILS/web/js/ui/default/vandelay/vandelay.js:1769: var method = '';
Open-ILS/web/js/ui/default/vandelay/vandelay.js:1774: ['open-ils.permacrud', method],
Open-ILS/web/js/ui/default/vandelay/vandelay.js:1902: var method = 'open-ils.permacrud' + (isCreate ? '.create.' : '.update.')
Open-ILS/web/js/ui/default/vandelay/vandelay.js:1909: ['open-ils.permacrud', method],
Open-ILS/web/js/ui/default/vandelay/vandelay.js:1934: var method = 'open-ils.permacrud.delete.' + (isAuth ? 'vqarad' : 'vqbrad');
Open-ILS/web/js/ui/default/vandelay/vandelay.js:1937: ['open-ils.permacrud', method],
Open-ILS/xul/staff_client/chrome/content/cat/opac.js:711: 'open-ils.permacrud',
Open-ILS/xul/staff_client/chrome/content/cat/opac.js:712: 'open-ils.permacrud.delete.sre',
Open-ILS/xul/staff_client/chrome/content/cat/opac.js:750: var method = 'open-ils.permacrud.update.' + rec.classname;
Open-ILS/xul/staff_client/chrome/content/cat/opac.js:753: 'open-ils.permacrud', method,

Evergreen master

Galen Charlton (gmc)
Changed in evergreen:
milestone: none → 3.0-alpha
Jeff Godin (jgodin)
Changed in evergreen:
assignee: nobody → Jeff Godin (jgodin)
Changed in evergreen:
milestone: 3.0-beta →
Remington Steed (rjs7)
tags: added: deprecation
Bill Erickson (berick)
Changed in evergreen:
assignee: Jeff Godin (jgodin) → nobody
Revision history for this message
Bill Erickson (berick) wrote :

Here's a branch to remove the offending code, but I have not yet tested the code paths where open-ils.permacrud was replaced with open-ils.pcrud. In theory, it should just work -- confirmation pending.;a=shortlog;h=refs/heads/user/berick/lp1680566-deprecate-permacrud

Revision history for this message
Jeff Godin (jgodin) wrote :
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Jeff. You caught a few things I missed (and added release, notes, yay). We still need to merge my .js file changes (migrating to open-ils.pcrud) into the final branch.

Revision history for this message
Bill Erickson (berick) wrote :

Scratch my previous comment, I missed one of Jeff's commit. +1 to Jeff's branch.

Jeff Godin (jgodin)
tags: added: pullrequest
Bill Erickson (berick)
Changed in evergreen:
milestone: → 3.1-beta
status: New → Confirmed
Galen Charlton (gmc)
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
importance: Undecided → Wishlist
Revision history for this message
Galen Charlton (gmc) wrote :

Unfortunately, this isn't ready for 3.1. For create, update, and delete actions, open-ils.pcrud turns out to not be a drop-in replacement for open-ils.permacrud, as the former wants an explicit client session and a transaction opened before doing CUD, whereas open-ils.permacrud did not.

The branch collab/gmcharlt/lp1680566_more_permacrud_removal_work contains a patch that address the mismatch for the following areas:

    - creating, updating, and deleting bib and authority record display
      attributes in Vandelay
    - saving records when the XUL MARC editor is invoked from Vandelay
    - the translator popup-dialog (e.g., as used by the copy status admin page)

Left to do is handling deleting MFHDs and invoking the MARC editor on them (in the XUL client); note that that breakage would be moot with the release of 3.2 and the removal of the XUL client.

tags: removed: pullrequest
tags: added: needsrepatch
Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
Changed in evergreen:
milestone: 3.1-beta → 3.1-rc
Changed in evergreen:
milestone: 3.1-rc → none
tags: added: needswork
removed: needsrepatch
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.