Comment 3 for bug 1680312

Revision history for this message
Ben Shum (bshum) wrote :

According to Dan Scott, the oils_i18n_gettext needs us to have the IDs be unique so that it generates the output properly.

What we expect is that the PO itself gets generated as something like:

# id::ccvm.value__520 id::ccvm.value__897 id::ccvm.value__1565
# id::ccvm.value__1585
#: 950.data.seed-values.sql:7069 950.data.seed-values.sql:7875
#: 950.data.seed-values.sql:8580 950.data.seed-values.sql:8601
msgid "Poetry"
msgstr ""

Whereby the ccvm.value IDs get assigned as comments in the block. The message string itself is only translated once, but the comments with the IDs are used to uniquely generate and apply translation against the individual values.

Right now, that block's comments end up like:

# id::ccvm.value__520 id::ccvm.value__897 id::ccvm.value__897
# id::ccvm.value__897

And thus creates at least two duplicate 897 INSERT entries in the compiled 950 seed data file for a given locale.

Tested my patch and updated the POT (templates) to see the new IDs take effect. Not sure yet if we have to push those changes first, then do a new PO sync to get updated locale files, then try rebuilding the 950 seed data localized files to fully re-test.