Update staff JS dependencies for Angular 1.6

Bug #1680140 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Confirmed
Wishlist
Unassigned

Bug Description

Evergreen currently uses Angular 1.5. Angular JS stable version as of writing is 1.6.3. We should catch up.

Revision history for this message
Galen Charlton (gmc) wrote :

Going through changes in 1.6:

- Open-ILS/web/js/ui/default/staff/services/print.js uses the .success() and .error() methods in $http, so we'll need to convert that to .then()
- there may be a number of places where pre-assigning bindings in controller instances will break; see https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$compile

Changed in evergreen:
milestone: none → 3.0-alpha
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Bill Erickson (berick) wrote :

Branch pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/berick/lp1680140-angular-1.6

From the commit:

Rebuild package.json starting with Angular 1.6. This resulted in a number of dependency updates and small changes required to keep the dependencies happy.

Fixes include:

* Teach print.js to use promise-style $http responses, instead of .success() and .error()
* Remove unused '$http' dependency in hatch.js
* Fix egDate custom test matcher to work with newer version of karma-jasmine.
* Build IDL for test scripts using Grunt/exec "cwd" since Grunt fails to understand "&&" commands, like 'cd foo && bar'.

==

Regarding the change for 'bindings', I didn't see any use of that in our code with a simple grep. I maybe oversimplifying the issue, but I don't believe there's anything we need to do for that.

To install the branch, I suggest deleting the 'node_modules' directory and starting over with a fresh 'npm install' and 'grunt all'.

tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Removing pullrequest. This will need review and rebase after 3.0 code rush.

tags: removed: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Consider merging with bug #1692097 which will touch some of the same files.

Bill Erickson (berick)
Changed in evergreen:
milestone: 3.0-alpha → none
Revision history for this message
Bill Erickson (berick) wrote :

Current plan is to revisit and possibly merge just prior to 3.0 Beta -- last week of August.

Revision history for this message
Bill Erickson (berick) wrote :

This got lost in the shuffle. Re-targeting for 3.next.

Changed in evergreen:
milestone: none → 3.next
Revision history for this message
Bill Erickson (berick) wrote :

Will likely be superseded by bug #1739803

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.