Hold targeter v2 fails to properly group parallel batches

[Bill Erickson]

Evergreen 2.12

The new hold targeter attempts to segregate parallel targeting batches by the metarecord ultimately linked to from the hold target. This prevents any 2 processes from targeting holds that share potential copies. The logic that implements this is flawed, though, because it's grouping on the metarecord_source_map.id column instead of the intended metarecord_source_map.metarecord column. As such, the groupings are essentially random.

Patch en route.

[Bill Erickson (berick)]

Fix pushed:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1679279-hold-targeter-parallel-grouping-repair

This is not easily tested via a Perl test, but one way to confirm the fix is to check that the SQL for main holds-to-target query (in parallel mode) now shows:

mod("mmrsm".metarecord, x) = y

Instead of:

mod("mmrsm".id, x) = y

[Kathy Lussier (klussier)]

Bill,

Is this bug ready for a pullrequest?

Kathy

[Bill Erickson (berick)]

Oops, adding pullrequest. Thanks Kathy.

[Kathy Lussier (klussier)]

Thanks Bill! Merged to master and backported to 2.12