installing broken translations should fail more loudly

Bug #1675216 reported by Galen Charlton on 2017-03-22
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

The issue fixed by 713bb9472 resulted in the es-ES localization have a zero-size lang.dtd, but it was easy to miss the error message for lack of tests to verify the output and either build/i18n/Makefile or build/tools/make_release not terminating.

It would be good to make it easier to (a) have the build server test for this sort of thing and (b) make it harder for tarball builders to miss it.

Evergreen 2.11 and later

Galen Charlton (gmc) on 2017-03-22
Changed in evergreen:
importance: Undecided → Medium
milestone: none →
description: updated
tags: added: i18n
Ben Shum (bshum) wrote :

So, using pofilter here seems to potentially be a good detection for problems.

For example, running "pofilter -t printf tpac tpac-check" in Open-ILS/build/i18n/po folder, gets me just the printf check against all the tpac template files and puts them in a new folder called tpac-check.

Checking the output in that folder, I get example issues like in cs-CZ.po:

# (pofilter) printf: Missing printf variable: %1
#. (facet.cmf.label)
#: ../../Open-ILS/src/templates/opac/parts/result/facets.tt2:71
msgid "Show Fewer %1 Entries"
msgstr "Zobrazit méně údajů %"

This helps us to catch potential breakage in the template file where the variables are not set right.

pofilter has 40+ tests and checks that we can run through to help us validate and test i18n strings for problems, with stuff like whitespace checks, variables, punctuation, capitalization, etc.

I'm also seeing lots of false positives in the test runs where it looks like it might be okay, and the test is being too aggressive. It'll require both input from the developers who run the validations, and also the translators to assist with fixes. Perhaps this is a good opportunity to teach translators the approaches available to validate their strings. Alternatively, use of certain translation tools like Pootle could allow us to include pofilter checks natively as part of the translation interface, and have it more interactive experience for translators downstream.

Changed in evergreen:
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers