Web Client: Right click problems on links in web client grids

[Michele Morgan]

Evergreen 2.12beta

When viewing the items in a copy bucket:

- The displayed copy barcode links to Item Status with a LEFT click.
- The displayed title links to the Opac View of the record with a LEFT click.
- A RIGHT click on a row opens the Actions menu for the item

If the user does not check one of the checkboxes to select an item, a RIGHT-click on the barcode or title will act as a LEFT click.

As long as any one of the checkboxes on the screen is checked, a RIGHT click while hovering over the barcode or title will open the actions menu.

A quick screencast to illustrate can be found at:

https://www.screencast.com/t/VFQctf4kzWP

The clicks on barcodes and titles are RIGHT clicks. The actions menu opens, but the screen quickly shifts to item status or opac view.

[Michele Morgan (mmorgan)]

A clarification and further thoughts on this.

The right click problems actually occur in all the grids in the web client. I updated the name of the bug appropriately.

Also, after further thought, I would expect that when right clicking on a link in a grid, like a copy barcode, the context menu should come up, offering the user options to copy the link, open it in a new window or tab, etc.

Right clicking in a grid row anywhere other than on a link should open the Actions menu.

[Remington Steed (rjs7)]

Since this bug specifically describes the behavior of right-clicking on a link in a grid, I opened a new bug for the behavior of right-clicking on a grid row itself (bug #1776557).

[a. bellenir (abellenir)]

here's a branch that will give you the browser's built-in context menu when clicking on links in eg grids: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/abellenir/lp1669856-lp1776557-egGrid-right-click

this branch also attempts to address bug #1776557, since the two are closely related.

[Michele Morgan (mmorgan)]

This fix is working well.

It allows using the intuitive Right click on a link within in a grid row to open the context menu, allowing opening the link in a new tab, and preserving any selections already made in the grid in the current tab, which addresses bug 1669856

Also addresses the right click fails to select issue in bug 1776557 by clearing the current selection(s) in a grid and refocusing the selection to the right-clicked row before opening the Actions menu.

My signoff branch is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1669856-lp1776557-egGrid-right-click-signoff

I'm echoing this comment on both bugs.

[Chris Sharp (chrissharp123)]

Noted on bug 1776557, but this was pushed to master, rel_3_0 and rel_3_1.