JS error attempting to set client TZ

Bug #1668720 reported by Galen Charlton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned

Bug Description

The TPAC login page defines a hidden client_tz_id input as part of the mechanism for passing the client timezone in during authentication, but the JavaScript code that handles that input doesn't verify that this input exists before trying to set its value.

Consequently, when navigating to other pages in the OPAC, one sees the following error message in the JavaScript console:

Uncaught TypeError: Cannot set property 'value' of null

This is just noise, but noise that should be cleaned up.

Evergreen master/2.12

Tags: pullrequest
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Low
milestone: none → 2.12-rc
Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
Galen Charlton (gmc)
Changed in evergreen:
milestone: 2.12-rc → 2.12.0
Revision history for this message
Galen Charlton (gmc) wrote :

A patch is available in the user/gmcharlt/lp1668720_client_tz_console_noise branch in the working/Evergreen repository:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp1668720_client_tz_console_noise

tags: added: pullrequest
Kathy Lussier (klussier)
Changed in evergreen:
assignee: nobody → Kathy Lussier (klussier)
Revision history for this message
Kathy Lussier (klussier) wrote :

Thank you Galen! Works for me. Merged to master and release 2.12.

Changed in evergreen:
assignee: Kathy Lussier (klussier) → nobody
status: Confirmed → Fix Committed
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.