EDI: fetch can crash if file it's fetching zero-length
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned | ||
2.10 |
Fix Released
|
Undecided
|
Unassigned | ||
2.11 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Because of what appears to be an unfortunate interaction between Net::FTP 2.79, IO::Scalar 2.110, and Perl 5.20, if an EDI message provider supplies a zero-length file to retrieve via FTP, edi_fetcher.pl can crash with an error like this:
1 of X targets: ftp://example.
Use of uninitialized value $filename in concatenation (.) or string at /usr/local/
Can't use an undefined value as an ARRAY reference at /usr/local/
This of course breaks retrieving and processing any other EDI message files that may be available.
Despite the specific versions listed above, it's not clear to me if other versions are problematic, but the patch I'm writing shouldn't get in the way if other combinations of Net::FTP, IO::Scalar, and Perl versions don't have the problem.
Evergreen 2.10+
Changed in evergreen: | |
status: | New → Confirmed |
milestone: | none → 2.next |
Changed in evergreen: | |
milestone: | 2.next → 2.12-rc |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
no longer affects: | evergreen/2.12 |
A patch is available in the user/gmcharlt/ lp1667835_ edi_fetcher_ meets_zero branch:
git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ gmcharlt/ lp1667835_ edi_fetcher_ meets_zero