Log Noise - uninitialized value warnings - holds depth
Bug #1667497 reported by
Josh Stompro
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Medium
|
Unassigned | ||
3.1 |
Fix Released
|
Medium
|
Unassigned | ||
3.2 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
EG 2.10.6
We see a number of warnings like the following every day, 298 in 6 hours.
298 ] open-ils.
Line looks like
return () if $depth == $top_org-
We don't use any depth settings, so maybe that statement should return if $depth isn't defined or it equals $top_org-
Josh
Changed in evergreen: | |
assignee: | nobody → Jason Stephenson (jstephenson) |
status: | New → Confirmed |
importance: | Undecided → Medium |
milestone: | none → 3.3-rc |
tags: | added: signedoff |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Working branch at lp1667497_ set_depth_ undefied_ log_noise /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ stompro/ lp1667497_ set_depth_ undefied_ log_noise
user/stompro/
https:/
It just sets $params{depth} to $depth, so it gets set to 0 if not defined.
There is already a comment about this issue.
# FIXME: better params checking. what other params are required, if any?
# FIXME: 3 copies of values confusing: $x, $params->{x} and $params{x}
# FIXME: for example, $depth gets a default value, but then $$params{depth} is still
# used in conditionals, where it may be undefined, causing a warning.
# FIXME: specify proper usage/interaction of selection_ou and pickup_lib
Another solution would be to not use $params{depth} further down, but $depth seems like it might get changed before that, so maybe that is why it is used? This seemed like the simplest change to me.
Josh