Missing billing types in upgraded systems

[Chris Sharp]

A long time ago in a library development shop far, far away, some business logic was added to accommodate automatic billing for marking an item damaged:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=2a87597

A couple of weeks after that, a feature for adding a notification fee:

http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=c0c60f4

Unfortunately, none of the billing types added to accommodate these features made it into upgrade scripts. In fact, they pre-dated the numbered upgrade scripts by about 6 months, so we're talking ancient history here. Anyhoo, if you're one of the grizzled old systems that would have upgraded from 1.2-ish to 1.4-ish (c. first half of 2009), you may be missing them too.

Branch on the way.

[Chris Sharp (chrissharp123)]

Branch here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1666512_missing_billing_types_from_upgraded_systems

[Galen Charlton (gmc)]

For the sake of making this a fire-and-forget upgrade step, I suggest tweaking it so that it follows the INSERT INTO ... SELECT FROM ... WHERE NOT EXISTS pattern from (e.g.) 1000.data.add-spanish-to-i18n-locale.sql .

[Galen Charlton (gmc)]

Strengthening my comment of last month and turning it into a needsrepatch.

[Ben Shum (bshum)]

Rebased to current master, signed off on csharp's original commit and added a new repatched commit version on top of it in the style requested to avoid unnecessary INSERT failures.

See top two commits in branch: user/bshum/lp1666512_repatch

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/lp1666512_repatch

[Chris Sharp (chrissharp123)]

Oops! I totally dropped this after fixing it locally.

My signoff of Ben's repatch is here:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/csharp/lp1666512_repatch_signoff

[Galen Charlton (gmc)]

Pushed to master, rel_3_0, and rel_2_12. Thanks, Chris and Ben!