web client: title hold screen does not remember pickup library selection

Bug #1665534 reported by Kathy Lussier on 2017-02-17
40
This bug affects 8 people
Affects Status Importance Assigned to Milestone
Evergreen
Medium
Unassigned
3.0
Medium
Unassigned
3.1
Medium
Unassigned
3.2
Undecided
Unassigned

Bug Description

In the xul client when I am viewing holds for a title, it automatically displays the holds filtered by pickup library, with the OU set to the workstation library by default. I often remove the checkmark in the pickup library box to see all the holds in the consortium, regardless of pickup library. If I then retrieve more records and view the holds, the client remembers that I removed the checkmark and will automatically retrieve all holds in the consortium. It will also remember the last pickup location that was selected.

In the web client, I select consortium from the dropdown menu to see all the holds. However, the next time I retrieve a record or view holds on this record, it forgets what I had previously selected and always defaults the pickup library selector to the workstation library. This selector should remember the last OU that was selected and default to it the next time the interface is retrieved.

Andrea Neiman (aneiman) on 2017-03-02
Changed in evergreen:
status: New → Confirmed
status: Confirmed → New
Andrea Neiman (aneiman) wrote :

Not sure why I unconfirmed this in March, but, confirmed on 2.12 (and this time I mean it)

Changed in evergreen:
status: New → Confirmed
Kathy Lussier (klussier) on 2017-12-12
Changed in evergreen:
importance: Undecided → Medium
Pamela Smith (pamela-smith) wrote :

It is very problematic for us that the pickup library default in view holds is the login library & won't work the way it does in the staff client. It's an extra click every time you want to view holds & our staff finds it frustrating.

Some staff forget to switch the view, which leads to inaccurate information being conveyed to patrons.

Jane Sandberg (sandbej) wrote :

Here's a branch that makes this dropdown sticky: user/sandbergja/lp1665534_make_pickup_library_sticky

The link is: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1665534_make_pickup_library_sticky

tags: added: pullrequest
Michele Morgan (mmorgan) on 2018-09-10
Changed in evergreen:
assignee: nobody → Michele Morgan (mmorgan)
Michele Morgan (mmorgan) wrote :

I tested this on a sandbox running 3.2, and while the fix for the stickiness of the dropdown appears to work, I discovered bug 1792188 while testing. My plan is to try the sticky dropdown fix on 3.1 to avoid the interference from the new bug.

Michele Morgan (mmorgan) on 2018-09-14
tags: added: signedoff
Changed in evergreen:
assignee: Michele Morgan (mmorgan) → nobody
milestone: none → 3.2-rc
Michele Morgan (mmorgan) wrote :

I tested this on a 3.1 server and the stickiness of the pickup location dropdown works like a charm. My signoff branch is at:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mmorgan/lp1665534_make_pickup_library_sticky_signoff

Thanks Jane!

Kathy Lussier (klussier) wrote :

It works for me too, but, for 3.2, I think this workstation setting should be stored in the database instead of the browser since other similar settings work this way.

However, this sticky setting seems to be a little different from other local storage settings. In master, I don't get the Console warning we usually see when a workstation setting isn't available for database storage and adding this setting to config.workstation_setting_type doesn't result in the setting getting stored in the database. Something else must be required to get it to work.

Changed in evergreen:
milestone: 3.2-rc → 3.2.1
Changed in evergreen:
milestone: 3.2.1 → 3.2.2
Changed in evergreen:
milestone: 3.2.2 → 3.2.3
Changed in evergreen:
status: Confirmed → New
milestone: 3.2.3 → 3.3-beta1
Changed in evergreen:
milestone: 3.3-beta1 → 3.3-rc
Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick) on 2019-03-08
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Bill Erickson (berick) wrote :

I have opened bug #1819213 in response to Kathy's comments about storing the values as a workstation setting.

Issue and fix confirmed. Merged to 3.1 and above. Thanks Jane, Thanks Michele.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers